From: Cole Robinson <crobinso@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
pkg-qemu-devel@lists.alioth.debian.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] building rst docs with sphinx
Date: Tue, 29 Jan 2019 09:39:20 -0500 [thread overview]
Message-ID: <5ada804a-0832-e557-48b7-217e6213a9a0@redhat.com> (raw)
In-Reply-To: <20190129021815.GA3264@stefanha-x1.localdomain>
On 1/28/19 9:18 PM, Stefan Hajnoczi wrote:
> On Thu, Jan 24, 2019 at 06:56:09PM +0000, Peter Maydell wrote:
>> (1) configure: My thought is that we should just make
>> sphinx-build a requirement for the existing --enable-docs
>> switch (as texinfo and pod2man are currently). The
>> disadvantage is that we won't support a "build the half
>> of the docs you have the tools for and leave the others"
>> setup. The advantage, which I think is significant, is that
>> distros will naturally be directed to the missing build
>> dependency (either they're building with --enable-docs
>> and will get the configure message, or they aren't and
>> then their build will fail later because of missing docs
>> files when they try to put the built files into the package).
>
> I'm CCing Cole (Fedora) and the Debian QEMU team so they can give their
> input on this point and your next point.
>
Peter's assessment sounds correct to me. And sphinx is so widely
available that adding it as a build dep is no problem at all IMO
>> (2) What do we actually want to ship?
>> That is, what do we want 'make install-doc' to copy into
>> the installation directory?
>> https://wiki.qemu.org/Features/Documentation
>> has a good suggested breakdown of docs for where we
>> eventually want to be. I think we probably don't want
>> to install the "developer's guide" (docs/devel) on
>> end-user systems. The others are presumably OK.
>> Currently, we seem to only install manpages and a
>> few other things in the 'install-doc' makefile target
>> (we don't install a bunch of plain-text user-facing
>> docs) so this would be a significant expansion.
>
> I agree, developer documentation is not relevant to end-users.
>
Agreed as well. On my Fedora system I see that some packages install
HACKING/CONTRIBUTING files but even that seems a little weird. If qemu
cared about installing developer docs it could be a separate makefile
target so it's easy to control whether it's handled during package build
Thanks,
Cole
next prev parent reply other threads:[~2019-01-29 15:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 18:56 [Qemu-devel] building rst docs with sphinx Peter Maydell
2019-01-24 21:54 ` Philippe Mathieu-Daudé
2019-01-25 9:30 ` Peter Maydell
2019-01-29 2:18 ` Stefan Hajnoczi
2019-01-29 14:39 ` Cole Robinson [this message]
2019-01-29 10:36 ` Daniel P. Berrangé
2019-01-29 10:39 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ada804a-0832-e557-48b7-217e6213a9a0@redhat.com \
--to=crobinso@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pkg-qemu-devel@lists.alioth.debian.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).