From: Eric Blake <eblake@redhat.com>
To: "Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com,
kwolf@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH] iotests: 205: support luks format
Date: Tue, 6 Feb 2018 12:04:19 -0600 [thread overview]
Message-ID: <5af79798-357a-ab77-eae8-6e2e90e69707@redhat.com> (raw)
In-Reply-To: <b4ddc41e-0c96-7f91-96c6-957271baf6a4@virtuozzo.com>
On 02/06/2018 11:57 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> +luks_default_secret_id = 'luks_secret_default_iotests_id'
>> Can we just call this "keysec0", so we matchh convention used by
>> the shell script based tests.
>
> Here I'm trying to avoid intersection with some user-defined id.
>
You're overthinking it. We are only using this in the testsuite, and
nothing else in the testsuite is using 'keysec0' for anything except the
id of the secret to pass to encrypted disks. The longer name doesn't
add any protection. It might be different if we were trying to provide
a reusable library for contexts outside the testsuite, but since we are
not doing that, we can rely on 'make check' failing as evidence if we
have any collisions in naming choices that need long name munging as a
workaround.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-02-06 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 17:16 [Qemu-devel] [PATCH] iotests: 205: support luks format Vladimir Sementsov-Ogievskiy
2018-02-06 17:29 ` Daniel P. Berrangé
2018-02-06 17:57 ` Vladimir Sementsov-Ogievskiy
2018-02-06 18:04 ` Eric Blake [this message]
2018-02-06 18:07 ` Vladimir Sementsov-Ogievskiy
2018-02-06 18:07 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af79798-357a-ab77-eae8-6e2e90e69707@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).