From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs5Ub-0006ws-BY for qemu-devel@nongnu.org; Thu, 06 Oct 2016 06:01:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bs5UZ-00027g-Ec for qemu-devel@nongnu.org; Thu, 06 Oct 2016 06:01:32 -0400 References: <1475746836-16162-1-git-send-email-kwolf@redhat.com> From: Michal Privoznik Message-ID: <5b09c64b-a6ec-ccb2-22d0-0d6bffc1daf3@redhat.com> Date: Thu, 6 Oct 2016 12:01:20 +0200 MIME-Version: 1.0 In-Reply-To: <1475746836-16162-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: Add bdrv_runtime_opts to query-command-line-options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mkletzan@redhat.com, eblake@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 06.10.2016 11:40, Kevin Wolf wrote: > Recently we moved a few options from QemuOptsLists in blockdev.c to > bdrv_runtime_opts in block.c in order to make them accissble using > blockdev-add. However, this has the side effect that these options are > missing from query-command-line-options now, and libvirt consequently > disables the corresponding feature. > > This problem was reported as a regression for the 'discard' option, > introduced in commit 818584a4. However, it is more general than that. > > Fix it by adding bdrv_runtime_opts to the list of QemuOptsLists that are > returned in query-command-line-options. For the future, libvirt is > advised to use QMP schema introspection for block device options. > > Reported-by: Michal Privoznik > Signed-off-by: Kevin Wolf Tested-by: Michal Privoznik Thank you for such a prompt fix! Michal