From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Dmitry Fleytman <dmitry.fleytman@gmail.com>,
quintela@redhat.com
Subject: Re: [PATCH for 8.0 v2] igb: Save the entire Tx context descriptor
Date: Thu, 16 Mar 2023 17:07:09 +0100 [thread overview]
Message-ID: <5b224a32-cad8-28e9-3314-b57282771819@linaro.org> (raw)
In-Reply-To: <20230316155707.27007-1-akihiko.odaki@daynix.com>
On 16/3/23 16:57, Akihiko Odaki wrote:
> The current implementation of igb uses only part of a advanced Tx
> context descriptor because it misses some features and sniffs the trait
> of the packet instead of respecting the packet type specified in the
> descriptor. However, we will certainly need the entire Tx context
> descriptor when we update igb to respect these ignored fields. Save the
> entire Tx context descriptor to prepare for such a change.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> V1 -> V2: Bump igb-tx version
>
> hw/net/igb.c | 10 ++++++----
> hw/net/igb_core.c | 17 ++++++++++-------
> hw/net/igb_core.h | 3 +--
> 3 files changed, 17 insertions(+), 13 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-03-16 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 15:57 [PATCH for 8.0 v2] igb: Save the entire Tx context descriptor Akihiko Odaki
2023-03-16 16:07 ` Philippe Mathieu-Daudé [this message]
2023-03-16 16:58 ` Juan Quintela
2023-03-16 20:27 ` Sriram Yagnaraman
2023-03-17 5:46 ` Akihiko Odaki
2023-03-17 9:19 ` Sriram Yagnaraman
2023-03-17 11:12 ` Akihiko Odaki
2023-03-17 11:24 ` Sriram Yagnaraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b224a32-cad8-28e9-3314-b57282771819@linaro.org \
--to=philmd@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=dmitry.fleytman@gmail.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).