From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drZ7J-0002S3-31 for qemu-devel@nongnu.org; Mon, 11 Sep 2017 20:31:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drZ7I-0000Yt-CI for qemu-devel@nongnu.org; Mon, 11 Sep 2017 20:31:53 -0400 References: <20170911172022.4738-1-eblake@redhat.com> <20170911172022.4738-27-eblake@redhat.com> From: John Snow Message-ID: <5b23e7b5-b8f7-72c2-a7b7-73ba504abd06@redhat.com> Date: Mon, 11 Sep 2017 20:31:36 -0400 MIME-Version: 1.0 In-Reply-To: <20170911172022.4738-27-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into qtest_quit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: thuth@redhat.com, "open list:Floppy" , "Michael S. Tsirkin" , Jason Wang , Amit Shah , armbru@redhat.com, Alexander Graf , Keith Busch , "open list:sPAPR" , Gerd Hoffmann , Stefan Hajnoczi , pbonzini@redhat.com, =?UTF-8?Q?Andreas_F=c3=a4rber?= , "Dr. David Alan Gilbert" , David Gibson On 09/11/2017 01:20 PM, Eric Blake wrote: > Rather than have two similar shutdown functions, where one requires > the use of global_qtest in the header, it is better to have a single > shutdown function that still takes care of cleaning up global_qtest > if it is set. All callers are updated. > > Signed-off-by: Eric Blake > --- > tests/libqtest.h | 11 ----------- > tests/libqtest.c | 6 +++++- [...] > tests/fdc-test.c | 2 +- [...] > tests/ide-test.c | 2 +- Reviewed-by: John Snow The rest: "ACK." Change looks sane and I assume the rest of the patch is fairly straightforward mechanical changes. Everything still compiles and runs successfully.