[Qemu-devel] [PATCH] EEPRO 100 emulation

[Qemu-devel] [PATCH] EEPRO 100 emulation

[Filip Navara]

[-- Attachment #1.1: Type: text/plain, Size: 257 bytes --]

Not sure if this is usefull, but the Darwin network driver uses the "flow
control" registers, so it's not good idea to bail out and stop the emulation
if they're accessed. The registers aren't vital for the EEPRO 100 operation,
so no harm in ignoring them.

[-- Attachment #1.2: Type: text/html, Size: 284 bytes --]

[-- Attachment #2: qemu-eepro100-flow-control.patch --]
[-- Type: application/octet-stream, Size: 545 bytes --]

Index: hw/eepro100.c
===================================================================
RCS file: /sources/qemu/qemu/hw/eepro100.c,v
retrieving revision 1.3
diff -u -r1.3 eepro100.c
--- hw/eepro100.c	2 Jul 2007 13:38:46 -0000	1.3
+++ hw/eepro100.c	30 Aug 2007 20:47:43 -0000
@@ -1256,6 +1256,10 @@
         eepro100_interrupt(s, 0);
         break;
     case SCBPort + 3:
+    case 24:
+    case 25:
+    case 26:
+    case 27:
         logout("addr=%s val=0x%02x\n", regname(addr), val);
         break;
     case SCBeeprom:

Re: [Qemu-devel] [PATCH] EEPRO 100 emulation

[Thiemo Seufer]

Filip Navara wrote:
> Not sure if this is usefull, but the Darwin network driver uses the "flow
> control" registers, so it's not good idea to bail out and stop the emulation
> if they're accessed. The registers aren't vital for the EEPRO 100 operation,
> so no harm in ignoring them.

Could you make them symbolic names instead of magic constants?


Thiemo

Re: [Qemu-devel] [PATCH] EEPRO 100 emulation

[Filip Navara]

[-- Attachment #1.1: Type: text/plain, Size: 480 bytes --]

Here it is.

Best regards,
Filip Navara

On 9/10/07, Thiemo Seufer <ths@networkno.de> wrote:
>
> Filip Navara wrote:
> > Not sure if this is usefull, but the Darwin network driver uses the
> "flow
> > control" registers, so it's not good idea to bail out and stop the
> emulation
> > if they're accessed. The registers aren't vital for the EEPRO 100
> operation,
> > so no harm in ignoring them.
>
> Could you make them symbolic names instead of magic constants?
>
>
> Thiemo
>
>

[-- Attachment #1.2: Type: text/html, Size: 802 bytes --]

[-- Attachment #2: qemu-eepro100-flow-control.patch --]
[-- Type: application/octet-stream, Size: 891 bytes --]

Index: eepro100.c
===================================================================
RCS file: /sources/qemu/qemu/hw/eepro100.c,v
retrieving revision 1.3
diff -u -r1.3 eepro100.c
--- eepro100.c	2 Jul 2007 13:38:46 -0000	1.3
+++ eepro100.c	10 Sep 2007 08:38:51 -0000
@@ -140,6 +140,7 @@
     SCBflash = 12, SCBeeprom = 14,      /* EEPROM and flash memory control. */
     SCBCtrlMDI = 16,            /* MDI interface control. */
     SCBEarlyRx = 20,            /* Early receive byte count. */
+    SCBFlow = 24
 };
 
 /* A speedo3 transmit buffer descriptor with two buffers... */
@@ -1256,6 +1257,10 @@
         eepro100_interrupt(s, 0);
         break;
     case SCBPort + 3:
+    case SCBFlow:
+    case SCBFlow + 1:
+    case SCBFlow + 2:
+    case SCBFlow + 3:
         logout("addr=%s val=0x%02x\n", regname(addr), val);
         break;
     case SCBeeprom: