From: "Filip Navara" <xnavara@volny.cz>
To: Thiemo Seufer <ths@networkno.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] EEPRO 100 emulation
Date: Mon, 10 Sep 2007 10:42:41 +0200 [thread overview]
Message-ID: <5b31733c0709100142v2a2dcc79j64819f6a8e9d1ac7@mail.gmail.com> (raw)
In-Reply-To: <20070910001518.GB10713@networkno.de>
[-- Attachment #1.1: Type: text/plain, Size: 480 bytes --]
Here it is.
Best regards,
Filip Navara
On 9/10/07, Thiemo Seufer <ths@networkno.de> wrote:
>
> Filip Navara wrote:
> > Not sure if this is usefull, but the Darwin network driver uses the
> "flow
> > control" registers, so it's not good idea to bail out and stop the
> emulation
> > if they're accessed. The registers aren't vital for the EEPRO 100
> operation,
> > so no harm in ignoring them.
>
> Could you make them symbolic names instead of magic constants?
>
>
> Thiemo
>
>
[-- Attachment #1.2: Type: text/html, Size: 802 bytes --]
[-- Attachment #2: qemu-eepro100-flow-control.patch --]
[-- Type: application/octet-stream, Size: 891 bytes --]
Index: eepro100.c
===================================================================
RCS file: /sources/qemu/qemu/hw/eepro100.c,v
retrieving revision 1.3
diff -u -r1.3 eepro100.c
--- eepro100.c 2 Jul 2007 13:38:46 -0000 1.3
+++ eepro100.c 10 Sep 2007 08:38:51 -0000
@@ -140,6 +140,7 @@
SCBflash = 12, SCBeeprom = 14, /* EEPROM and flash memory control. */
SCBCtrlMDI = 16, /* MDI interface control. */
SCBEarlyRx = 20, /* Early receive byte count. */
+ SCBFlow = 24
};
/* A speedo3 transmit buffer descriptor with two buffers... */
@@ -1256,6 +1257,10 @@
eepro100_interrupt(s, 0);
break;
case SCBPort + 3:
+ case SCBFlow:
+ case SCBFlow + 1:
+ case SCBFlow + 2:
+ case SCBFlow + 3:
logout("addr=%s val=0x%02x\n", regname(addr), val);
break;
case SCBeeprom:
prev parent reply other threads:[~2007-09-10 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 19:32 [Qemu-devel] [PATCH] EEPRO 100 emulation Filip Navara
2007-09-10 0:15 ` Thiemo Seufer
2007-09-10 8:42 ` Filip Navara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b31733c0709100142v2a2dcc79j64819f6a8e9d1ac7@mail.gmail.com \
--to=xnavara@volny.cz \
--cc=qemu-devel@nongnu.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).