From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IUer1-0003Ya-LJ
	for qemu-devel@nongnu.org; Mon, 10 Sep 2007 04:42:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IUeqy-0003VU-D3
	for qemu-devel@nongnu.org; Mon, 10 Sep 2007 04:42:46 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IUeqx-0003VC-P0
	for qemu-devel@nongnu.org; Mon, 10 Sep 2007 04:42:43 -0400
Received: from nf-out-0910.google.com ([64.233.182.187])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1IUeqx-0002TF-5S
	for qemu-devel@nongnu.org; Mon, 10 Sep 2007 04:42:43 -0400
Received: by nf-out-0910.google.com with SMTP id d21so1029122nfb
	for <qemu-devel@nongnu.org>; Mon, 10 Sep 2007 01:42:41 -0700 (PDT)
Message-ID: <5b31733c0709100142v2a2dcc79j64819f6a8e9d1ac7@mail.gmail.com>
Date: Mon, 10 Sep 2007 10:42:41 +0200
From: "Filip Navara" <xnavara@volny.cz>
Sender: filip.navara@gmail.com
Subject: Re: [Qemu-devel] [PATCH] EEPRO 100 emulation
In-Reply-To: <20070910001518.GB10713@networkno.de>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_Part_7541_25126830.1189413761511"
References: <5b31733c0709081232n6f7a6c0l2471f0b738f63a7c@mail.gmail.com>
	<20070910001518.GB10713@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thiemo Seufer <ths@networkno.de>
Cc: qemu-devel@nongnu.org

------=_Part_7541_25126830.1189413761511
Content-Type: multipart/alternative;
	boundary="----=_Part_7542_16510783.1189413761511"

------=_Part_7542_16510783.1189413761511
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Here it is.

Best regards,
Filip Navara

On 9/10/07, Thiemo Seufer <ths@networkno.de> wrote:
>
> Filip Navara wrote:
> > Not sure if this is usefull, but the Darwin network driver uses the
> "flow
> > control" registers, so it's not good idea to bail out and stop the
> emulation
> > if they're accessed. The registers aren't vital for the EEPRO 100
> operation,
> > so no harm in ignoring them.
>
> Could you make them symbolic names instead of magic constants?
>
>
> Thiemo
>
>

------=_Part_7542_16510783.1189413761511
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Here it is.<br><br>Best regards,<br>Filip Navara<br><br><div><span class="gmail_quote">On 9/10/07, <b class="gmail_sendername">Thiemo Seufer</b> &lt;<a href="mailto:ths@networkno.de">ths@networkno.de</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Filip Navara wrote:<br>&gt; Not sure if this is usefull, but the Darwin network driver uses the &quot;flow<br>&gt; control&quot; registers, so it&#39;s not good idea to bail out and stop the emulation<br>&gt; if they&#39;re accessed. The registers aren&#39;t vital for the EEPRO 100 operation,
<br>&gt; so no harm in ignoring them.<br><br>Could you make them symbolic names instead of magic constants?<br><br><br>Thiemo<br><br></blockquote></div><br>

------=_Part_7542_16510783.1189413761511--

------=_Part_7541_25126830.1189413761511
Content-Type: application/octet-stream;
 name="qemu-eepro100-flow-control.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="qemu-eepro100-flow-control.patch"
X-Attachment-Id: f_f6eq7sjp

SW5kZXg6IGVlcHJvMTAwLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvc291cmNlcy9xZW11L3Fl
bXUvaHcvZWVwcm8xMDAuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMw0KZGlmZiAtdSAtcjEu
MyBlZXBybzEwMC5jDQotLS0gZWVwcm8xMDAuYwkyIEp1bCAyMDA3IDEzOjM4OjQ2IC0wMDAwCTEu
Mw0KKysrIGVlcHJvMTAwLmMJMTAgU2VwIDIwMDcgMDg6Mzg6NTEgLTAwMDANCkBAIC0xNDAsNiAr
MTQwLDcgQEANCiAgICAgU0NCZmxhc2ggPSAxMiwgU0NCZWVwcm9tID0gMTQsICAgICAgLyogRUVQ
Uk9NIGFuZCBmbGFzaCBtZW1vcnkgY29udHJvbC4gKi8NCiAgICAgU0NCQ3RybE1ESSA9IDE2LCAg
ICAgICAgICAgIC8qIE1ESSBpbnRlcmZhY2UgY29udHJvbC4gKi8NCiAgICAgU0NCRWFybHlSeCA9
IDIwLCAgICAgICAgICAgIC8qIEVhcmx5IHJlY2VpdmUgYnl0ZSBjb3VudC4gKi8NCisgICAgU0NC
RmxvdyA9IDI0DQogfTsNCiANCiAvKiBBIHNwZWVkbzMgdHJhbnNtaXQgYnVmZmVyIGRlc2NyaXB0
b3Igd2l0aCB0d28gYnVmZmVycy4uLiAqLw0KQEAgLTEyNTYsNiArMTI1NywxMCBAQA0KICAgICAg
ICAgZWVwcm8xMDBfaW50ZXJydXB0KHMsIDApOw0KICAgICAgICAgYnJlYWs7DQogICAgIGNhc2Ug
U0NCUG9ydCArIDM6DQorICAgIGNhc2UgU0NCRmxvdzoNCisgICAgY2FzZSBTQ0JGbG93ICsgMToN
CisgICAgY2FzZSBTQ0JGbG93ICsgMjoNCisgICAgY2FzZSBTQ0JGbG93ICsgMzoNCiAgICAgICAg
IGxvZ291dCgiYWRkcj0lcyB2YWw9MHglMDJ4XG4iLCByZWduYW1lKGFkZHIpLCB2YWwpOw0KICAg
ICAgICAgYnJlYWs7DQogICAgIGNhc2UgU0NCZWVwcm9tOg0K
------=_Part_7541_25126830.1189413761511--