From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JGdXl-000826-S7 for qemu-devel@nongnu.org; Sun, 20 Jan 2008 12:01:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JGdXl-00081A-78 for qemu-devel@nongnu.org; Sun, 20 Jan 2008 12:01:13 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGdXk-00080t-RF for qemu-devel@nongnu.org; Sun, 20 Jan 2008 12:01:12 -0500 Received: from wa-out-1112.google.com ([209.85.146.176]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JGdXk-0005AM-7z for qemu-devel@nongnu.org; Sun, 20 Jan 2008 12:01:12 -0500 Received: by wa-out-1112.google.com with SMTP id k22so3363139waf.18 for ; Sun, 20 Jan 2008 09:01:10 -0800 (PST) Message-ID: <5b31733c0801200901k279a1f70g70835f45c2e26e07@mail.gmail.com> Date: Sun, 20 Jan 2008 18:01:10 +0100 From: "Filip Navara" Sender: filip.navara@gmail.com Subject: Re: [kvm-devel] [Qemu-devel] [PATCH 2 of 3] Optionally link against libuuid if present In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_12401_2172632.1200848470906" References: <115f40a4994be1d5b44e.1197403732@localhost.localdomain> <5b31733c0712111319s2109e935o19c9d51d091a4056@mail.gmail.com> <20080103195542.GT23913@us.ibm.com> <5b31733c0801200517m166d35aencd4a4233d5ac09cc@mail.gmail.com> <5b31733c0801200837u2425876dyd2b05a565b7eb023@mail.gmail.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: kvm-devel@lists.sourceforge.net, Ryan Harper , qemu-devel@nongnu.org ------=_Part_12401_2172632.1200848470906 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Jan 20, 2008 5:53 PM, Alexander Graf wrote: > > On Jan 20, 2008, at 5:37 PM, Filip Navara wrote: > > The specific VMware backdoor call isn't implemented, but the framework is > there and it wouldn't be hard to add support for it. The BIOS can fallback > to some "reasonable" value if the backdoor isn't available. > > > + memset(bios_uuid, 0, 16); > > This value? Why not put something more "reasonable" in there? Does a uuid > have to meet specific criteria (checksums)? If not, why not simply put > something like "QEMU" in here? If I remember correctly OSX needs a value in > the uuid or it fails to boot, so it might be a good idea to give it > something better than an empty string. > Yes, this value. All zeroes means that UUID is not present in the system. The value has to follow the criteria of SMBIOS specification, section 3.3.2.1, namely it has to be formatted like this: DWORD time_low; WORD time_mid; WORD time_high_and_version; BYTE clock_seq_hi_and_reserved; BYTE clock_seq_low; BYTE node_number[6]; I doubt any driver really checks the value, except maybe for the all-0xFF or all-0x00 case. - Filip ------=_Part_12401_2172632.1200848470906 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Jan 20, 2008 5:53 PM, Alexander Graf <alex@csgraf.de> wrote:

On Jan 20, 2008, at 5:37 PM, Filip Navara wrote:

The specific VMware backdoor call isn't implemented, but the framework is there and it wouldn't be hard to add support for it. The BIOS can fallback to some "reasonable" value if the backdoor isn't available.


+        memset(bios_uuid, 0, 16);

This value? Why not put something more "reasonable" in there? Does a uuid have to meet specific criteria (checksums)? If not, why not simply put something like "QEMU" in here? If I remember correctly OSX needs a value in the uuid or it fails to boot, so it might be a good idea to give it something better than an empty string.

Yes, this value. All zeroes means that UUID is not present in the system. The value has to follow the criteria of SMBIOS specification, section 3.3.2.1 , namely it has to be formatted like this:

DWORD time_low;
WORD time_mid;
WORD time_high_and_version;
BYTE clock_seq_hi_and_reserved;
BYTE clock_seq_low;
BYTE node_number[6];

I doubt any driver really checks the value, except maybe for the all-0xFF or all-0x00 case.

- Filip
------=_Part_12401_2172632.1200848470906--