From: "Filip Navara" <filip.navara@gmail.com>
To: qemu-devel@nongnu.org
Cc: paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] Initialize the VMware VGA console after vga_init
Date: Fri, 11 Jul 2008 16:25:12 +0200 [thread overview]
Message-ID: <5b31733c0807110725h23efd6f3oeff76a9bd447b4a1@mail.gmail.com> (raw)
In-Reply-To: <48737693.5030300@suse.de>
Reviewed-by: Filip Navara <filip.navara@gmail.com>
On Tue, Jul 8, 2008 at 4:15 PM, Alexander Graf <agraf@suse.de> wrote:
> Hi,
>
> while trying the -vmwarevga switch I stumbled across this nifty problem:
> vga_common_init calls vga_reset, which memsets the whole VGAState to 0.
> Unfortunately the console initialization code is before that, so it gets
> overwritten by 0 which breaks later on.
>
> To circumvent this I reordered the console initialization to after the
> vga_init. I am not 100% sure if that's correct, but it works so far. Please
> double-check if this is the right approach.
>
> Alex
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
>
>
>
prev parent reply other threads:[~2008-07-11 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 14:15 [Qemu-devel] [PATCH] Initialize the VMware VGA console after vga_init Alexander Graf
2008-07-08 16:44 ` Rick Vernam
2008-07-11 14:25 ` Filip Navara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b31733c0807110725h23efd6f3oeff76a9bd447b4a1@mail.gmail.com \
--to=filip.navara@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).