From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KHJYi-0000wp-8d for qemu-devel@nongnu.org; Fri, 11 Jul 2008 10:25:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KHJYg-0000tM-2x for qemu-devel@nongnu.org; Fri, 11 Jul 2008 10:25:15 -0400 Received: from [199.232.76.173] (port=34688 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHJYf-0000sz-Tp for qemu-devel@nongnu.org; Fri, 11 Jul 2008 10:25:13 -0400 Received: from wr-out-0506.google.com ([64.233.184.231]:7576) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KHJYf-0000gs-Rt for qemu-devel@nongnu.org; Fri, 11 Jul 2008 10:25:13 -0400 Received: by wr-out-0506.google.com with SMTP id c46so3392786wra.18 for ; Fri, 11 Jul 2008 07:25:12 -0700 (PDT) Message-ID: <5b31733c0807110725h23efd6f3oeff76a9bd447b4a1@mail.gmail.com> Date: Fri, 11 Jul 2008 16:25:12 +0200 From: "Filip Navara" Subject: Re: [Qemu-devel] [PATCH] Initialize the VMware VGA console after vga_init In-Reply-To: <48737693.5030300@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48737693.5030300@suse.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: paul@codesourcery.com Reviewed-by: Filip Navara On Tue, Jul 8, 2008 at 4:15 PM, Alexander Graf wrote: > Hi, > > while trying the -vmwarevga switch I stumbled across this nifty problem: > vga_common_init calls vga_reset, which memsets the whole VGAState to 0. > Unfortunately the console initialization code is before that, so it gets > overwritten by 0 which breaks later on. > > To circumvent this I reordered the console initialization to after the > vga_init. I am not 100% sure if that's correct, but it works so far. Please > double-check if this is the right approach. > > Alex > > Signed-off-by: Alexander Graf > > >