From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MFujS-0005Ze-9P for qemu-devel@nongnu.org; Sun, 14 Jun 2009 14:47:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MFujM-0005Xl-SY for qemu-devel@nongnu.org; Sun, 14 Jun 2009 14:47:05 -0400 Received: from [199.232.76.173] (port=52088 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MFujM-0005Xi-O4 for qemu-devel@nongnu.org; Sun, 14 Jun 2009 14:47:00 -0400 Received: from mail-ew0-f224.google.com ([209.85.219.224]:57134) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MFujM-0001fh-9y for qemu-devel@nongnu.org; Sun, 14 Jun 2009 14:47:00 -0400 Received: by ewy24 with SMTP id 24so570880ewy.34 for ; Sun, 14 Jun 2009 11:46:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4A35403C.3020409@web.de> References: <4A353BE2.5060204@web.de> <4A35403C.3020409@web.de> Date: Sun, 14 Jun 2009 20:46:58 +0200 Message-ID: <5b31733c0906141146n7927cf77ga36ae0c455d501b0@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks From: Filip Navara Content-Type: multipart/alternative; boundary=0016364d2aa7d37662046c535da0 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Blue Swirl , qemu-devel --0016364d2aa7d37662046c535da0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Sun, Jun 14, 2009 at 8:23 PM, Jan Kiszka wrote: > Blue Swirl wrote: > > On 6/14/09, Jan Kiszka wrote: > >> [ I can't check the situation with cygwin, so this is mingw-only. ] > >> > >> gcc still does not support the Windows-specific format string modifier > >> "I64". Therefore, it makes no sense to check for format string > >> correctness and generate tons of false positives. > > > > I don't have this problem, currently mingw builds with zero warnings > > for me. But I didn't enable automatic -Werror flag for mingw just > > because I guessed this would happen. What's the gcc version you're > > using? > > i686-pc-mingw32-gcc (GCC) 4.3.3 > > Jan > > JFYI, for years there was a mingw32 patch for the format strings that wasn't merged into the mainline gcc. It was in the MinGW patches for at least 4 years. Not sure if it was merged now or not.. Best regards, Filip Navara --0016364d2aa7d37662046c535da0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Sun, Jun 14, 2009 at 8:23 PM, Jan Kiszka <ja= n.kiszka@web.de> wrote:
Blue Swirl wrote:
> On 6/14/09, Jan Kiszka <jan.kiszka@web.de> wrote:
>> [ I can't check the situation with cygwin, so this is mingw-on= ly. ]
>>
>> =A0gcc still does not support the Windows-specific format string m= odifier
>> =A0"I64". Therefore, it makes no sense to check for form= at string
>> =A0correctness and generate tons of false positives.
>
> I don't have this problem, currently mingw builds with zero warnin= gs
> for me. But I didn't enable automatic -Werror flag for mingw just<= br> > because I guessed this would happen. What's the gcc version you= 9;re
> using?

i686-pc-mingw32-gcc (GCC) 4.3.3

Jan

JFYI, for years there was a mingw32 patch for the= format strings that wasn't merged into the mainline gcc. It was in the= MinGW patches for at least 4 years. Not sure if it was merged now or not..=

Best regards,
Filip Navara
--0016364d2aa7d37662046c535da0--