[Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers

[Filip Navara <filip.navara@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]

On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguori <aliguori@us.ibm.com>wrote:

> From: Anthony Liguori <aliguori@us.ibm.com>
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> diff --git a/Makefile b/Makefile
> index 3177616..209b21f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h
>
>  sdl.o: sdl.c keymaps.h sdl_keysym.h
>
> -sdl.o audio/sdlaudio.o: CFLAGS += $(SDL_CFLAGS)
> +sdl.o audio/sdlaudio.o baum.o: CFLAGS += $(SDL_CFLAGS)
>
>  acl.o: acl.h acl.c
>
> diff --git a/Makefile.target b/Makefile.target
> index 27de4b9..0159bf7 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -730,6 +730,8 @@ LDFLAGS+=-p
>  main.o: CFLAGS+=-p
>  endif
>
> +vl.o: CFLAGS+=$(SDL_CFLAGS)
> +
>  vl.o: qemu-options.h
>
>  monitor.o: qemu-monitor.h
>
>
>
Please note that this commits breaks the Win32 port in several ways. First
problem is the SDL_main definition as already pointed out on the mailing
list. The other problem is that default mingw32 builds of SDL redirect
stderr/stdout through the SDL_main hack (and in incorrect way too, but I
will leave that for the SDL folks), so it's nearly impossible to get console
output - ie. error messages or help.

The only workaround I know is to build SDL with the
--disable-stdio-redirect, which is a bit annoying.

Best regards,
Filip Navara

[-- Attachment #2: Type: text/html, Size: 1846 bytes --]