From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIJsc-00038P-AK for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:02:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIJsW-000372-K3 for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:02:29 -0400 Received: from [199.232.76.173] (port=57459 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIJsW-00036m-0a for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:02:24 -0400 Received: from mail-ew0-f223.google.com ([209.85.219.223]:54614) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIJsV-00032c-CO for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:02:23 -0400 Received: by ewy23 with SMTP id 23so682833ewy.34 for ; Sun, 21 Jun 2009 03:02:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> References: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> Date: Sun, 21 Jun 2009 12:02:21 +0200 Message-ID: <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> From: Filip Navara Content-Type: multipart/alternative; boundary=0016364d226183c749046cd8dad6 Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel --0016364d226183c749046cd8dad6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguori wrote: > From: Anthony Liguori > > Signed-off-by: Anthony Liguori > > diff --git a/Makefile b/Makefile > index 3177616..209b21f 100644 > --- a/Makefile > +++ b/Makefile > @@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h > > sdl.o: sdl.c keymaps.h sdl_keysym.h > > -sdl.o audio/sdlaudio.o: CFLAGS += $(SDL_CFLAGS) > +sdl.o audio/sdlaudio.o baum.o: CFLAGS += $(SDL_CFLAGS) > > acl.o: acl.h acl.c > > diff --git a/Makefile.target b/Makefile.target > index 27de4b9..0159bf7 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -730,6 +730,8 @@ LDFLAGS+=-p > main.o: CFLAGS+=-p > endif > > +vl.o: CFLAGS+=$(SDL_CFLAGS) > + > vl.o: qemu-options.h > > monitor.o: qemu-monitor.h > > > Please note that this commits breaks the Win32 port in several ways. First problem is the SDL_main definition as already pointed out on the mailing list. The other problem is that default mingw32 builds of SDL redirect stderr/stdout through the SDL_main hack (and in incorrect way too, but I will leave that for the SDL folks), so it's nearly impossible to get console output - ie. error messages or help. The only workaround I know is to build SDL with the --disable-stdio-redirect, which is a bit annoying. Best regards, Filip Navara --0016364d226183c749046cd8dad6 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguor= i <aliguori@us.= ibm.com> wrote:
From: Anthony Liguori <aliguori@u= s.ibm.com>

Signed-off-by: Anthony Liguori <a= liguori@us.ibm.com>

diff --git a/Makefile b/Makefile
index 3177616..209b21f 100644
--- a/Makefile
+++ b/Makefile
@@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h

=A0sdl.o: sdl.c keymaps.h sdl_keysym.h

-sdl.o audio/sdlaudio.o: CFLAGS +=3D $(SDL_CFLAGS)
+sdl.o audio/sdlaudio.o baum.o: CFLAGS +=3D $(SDL_CFLAGS)

=A0acl.o: acl.h acl.c

diff --git a/Makefile.target b/Makefile.target
index 27de4b9..0159bf7 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -730,6 +730,8 @@ LDFLAGS+=3D-p
=A0main.o: CFLAGS+=3D-p
=A0endif

+vl.o: CFLAGS+=3D$(SDL_CFLAGS)
+
=A0vl.o: qemu-options.h

=A0monitor.o: qemu-monitor.h



Please note that this commits breaks the Win32 = port in several ways. First problem is the SDL_main definition as already p= ointed out on the mailing list. The other problem is that default mingw32 b= uilds of SDL redirect stderr/stdout through the SDL_main hack (and in incor= rect way too, but I will leave that for the SDL folks), so it's nearly = impossible to get console output - ie. error messages or help.

The only workaround I know is to build SDL with the --d= isable-stdio-redirect, which is a bit annoying.

Be= st regards,
Filip Navara
--0016364d226183c749046cd8dad6--