From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MIK5U-0006P5-RZ
	for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:15:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MIK5Q-0006N4-8T
	for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:15:48 -0400
Received: from [199.232.76.173] (port=46074 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MIK5P-0006Mr-3B
	for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:15:43 -0400
Received: from mail-ew0-f223.google.com ([209.85.219.223]:35823)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1MIK5O-0005F6-HK
	for qemu-devel@nongnu.org; Sun, 21 Jun 2009 06:15:42 -0400
Received: by ewy23 with SMTP id 23so686863ewy.34
	for <qemu-devel@nongnu.org>; Sun, 21 Jun 2009 03:15:41 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com>
References: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com>
	<5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com>
Date: Sun, 21 Jun 2009 12:15:41 +0200
Message-ID: <5b31733c0906210315w60a40e85r3e5a11372c8ddd9@mail.gmail.com>
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use
	SDL_CFLAGS everywhere we includeSDL headers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Sun, Jun 21, 2009 at 12:02 PM, Filip Navara <filip.navara@gmail.com> wro=
te:
>
> On Tue, Jun 16, 2009 at 10:33 PM, Anthony Liguori <aliguori@us.ibm.com> w=
rote:
>>
>> From: Anthony Liguori <aliguori@us.ibm.com>
>>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>> diff --git a/Makefile b/Makefile
>> index 3177616..209b21f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -208,7 +208,7 @@ keymaps.o: keymaps.c keymaps.h
>>
>> =A0sdl.o: sdl.c keymaps.h sdl_keysym.h
>>
>> -sdl.o audio/sdlaudio.o: CFLAGS +=3D $(SDL_CFLAGS)
>> +sdl.o audio/sdlaudio.o baum.o: CFLAGS +=3D $(SDL_CFLAGS)
>>
>> =A0acl.o: acl.h acl.c
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 27de4b9..0159bf7 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -730,6 +730,8 @@ LDFLAGS+=3D-p
>> =A0main.o: CFLAGS+=3D-p
>> =A0endif
>>
>> +vl.o: CFLAGS+=3D$(SDL_CFLAGS)
>> +
>> =A0vl.o: qemu-options.h
>>
>> =A0monitor.o: qemu-monitor.h
>>
>>
>
> Please note that this commits breaks the Win32 port in several ways. Firs=
t problem is the SDL_main definition as already pointed out on the mailing =
list. The other problem is that default mingw32 builds of SDL redirect stde=
rr/stdout through the SDL_main hack (and in incorrect way too, but I will l=
eave that for the SDL folks), so it's nearly impossible to get console outp=
ut - ie. error messages or help.
> The only workaround I know is to build SDL with the --disable-stdio-redir=
ect, which is a bit annoying.

Or rather "./configure=A0--enable-stdio-redirect=3Dno".

F.