From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIbub-0002G1-Ve for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:17:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIbuW-00029g-Mk for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:17:44 -0400 Received: from [199.232.76.173] (port=49738 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIbuW-00029d-Eb for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:17:40 -0400 Received: from mail-fx0-f209.google.com ([209.85.220.209]:48100) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIbuV-0001SS-7n for qemu-devel@nongnu.org; Mon, 22 Jun 2009 01:17:40 -0400 Received: by fxm5 with SMTP id 5so2558540fxm.34 for ; Sun, 21 Jun 2009 22:17:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5b31733c0906212202h2e77804aq7e856f1dd2f016e4@mail.gmail.com> References: <200906162031.n5GKVkTW025657@d01av03.pok.ibm.com> <5b31733c0906210302i5b633454w6f2954d7fb5cfeee@mail.gmail.com> <4A3EC618.2000200@codemonkey.ws> <5b31733c0906212202h2e77804aq7e856f1dd2f016e4@mail.gmail.com> Date: Mon, 22 Jun 2009 07:17:38 +0200 Message-ID: <5b31733c0906212217m196bd22cm58b525df02906325@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 537fe2d] Make sure to use SDL_CFLAGS everywhere we includeSDL headers From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel On Mon, Jun 22, 2009 at 7:02 AM, Filip Navara wrote: > On Mon, Jun 22, 2009 at 1:45 AM, Anthony Liguori wrote: >> Filip Navara wrote: >>> >>> Please note that this commits breaks the Win32 port in several ways. First >>> problem is the SDL_main definition as already pointed out on the mailing >>> list. The other problem is that default mingw32 builds of SDL redirect >>> stderr/stdout through the SDL_main hack (and in incorrect way too, but I >>> will leave that for the SDL folks), so it's nearly impossible to getconsole >>> output - ie. error messages or help. >> >> I have a fix in queue, but... >> >> For mingw32 we don't want to use SDL_main? > > I guess a cleaner approach would be to use SDL_main to keep the code > simple and portable. I've seen some crashes in the the past that could > be related to the DirectX initialization in the SDL's main wrapper. On > the other hand it requires a custom SDL build (only libSDLmain.a, not > the sdl.dll) and that should be documented at least. > >> But we want to use it for OS X? > > For OS X it's absolutely necessary, it initializes the QuickDraw libraries. I've checked the latest SDL source code in their svn since the official SDL release (1.2.13) is two years old already. SDL_main for OS X has been removed completely and on Win32 it no longer does any of the nasty stuff it used to do and is unnecessary too. Hopefully an official SDL 1.3 will be released soon and none of the hacks or custom builds will be required anymore... Wishful thinking, I know. Best regards, Filip Navara