From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ6BX-000894-Dz for qemu-devel@nongnu.org; Tue, 23 Jun 2009 09:37:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ6BW-00088Y-L0 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 09:37:14 -0400 Received: from [199.232.76.173] (port=44923 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ6BW-00088M-B4 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 09:37:14 -0400 Received: from ey-out-1920.google.com ([74.125.78.145]:51726) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ6BV-0002pp-AQ for qemu-devel@nongnu.org; Tue, 23 Jun 2009 09:37:13 -0400 Received: by ey-out-1920.google.com with SMTP id 3so6548eyh.4 for ; Tue, 23 Jun 2009 06:37:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1245763236-23464-1-git-send-email-avi@redhat.com> References: <1245763236-23464-1-git-send-email-avi@redhat.com> Date: Tue, 23 Jun 2009 15:37:12 +0200 Message-ID: <5b31733c0906230637s4ea687bdy837a136a98cc0a7f@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On Tue, Jun 23, 2009 at 3:20 PM, Avi Kivity wrote: > Commit 6a7ad299 ("Call qemu_bh_delete at bdrv_aio_bh_cb") deletes emulate= d > aio bottom halves to prevent endless accumulation. =A0However, it leaves = a > stale ->bh pointer, which is then waited on when the aio is reused. > > Zeroing the pointer fixes the issue, allowing vmdk format images to be us= ed. > > Signed-off-by: Avi Kivity It also fixes the qcow2 on Win32. At least "savevm" was broken. Acked-by: Filip Navara Best regards, Filip Navara