From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ7vM-0002se-JN for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:28:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ7vH-0002py-Ow for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:28:40 -0400 Received: from [199.232.76.173] (port=47361 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ7vH-0002pp-Hu for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:28:35 -0400 Received: from mail-ew0-f211.google.com ([209.85.219.211]:61292) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ7vG-0003Vw-UC for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:28:35 -0400 Received: by ewy7 with SMTP id 7so214989ewy.34 for ; Tue, 23 Jun 2009 08:28:22 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4A40EA58.6080600@redhat.com> References: <4A40EA58.6080600@redhat.com> Date: Tue, 23 Jun 2009 17:28:21 +0200 Message-ID: <5b31733c0906230828i65949383k3f30d77dc342115f@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH 1/2] Fix QCOW2 debugging code to compile with DEBUG_ALLOC defined. From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Tue, Jun 23, 2009 at 4:44 PM, Kevin Wolf wrote: > Filip Navara schrieb: >> Signed-off-by: Filip Navara >> --- >> =A0block/qcow2.c | =A0 =A02 +- >> =A01 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/block/qcow2.c b/block/qcow2.c >> index 9acbddf..fdcd20b 100644 >> --- a/block/qcow2.c >> +++ b/block/qcow2.c >> @@ -251,7 +251,7 @@ static int qcow_open(BlockDriverState *bs, const cha= r *filename, int flags) >> =A0 =A0 =A0 =A0 =A0goto fail; >> >> =A0#ifdef DEBUG_ALLOC >> - =A0 =A0check_refcounts(bs); >> + =A0 =A0qcow2_check_refcounts(bs); >> =A0#endif >> =A0 =A0 =A0return 0; >> > > Good point. However, this is not complete. During the qcow2 source split > the #ifdefs have been spread over the files, but the #define hasn't > moved to qcow2.h. To fix debugging you should move it there and fix the > additional compile errors in the other files, too. Also, defining > DEBUG_ALLOC2 gives even more errors, so maybe they should handled here > as well. > > Kevin I have sent a new patch that fixes all the QCOW2 debugging code in my environment and moves the definitions to qcow2.h. Thanks for comments. Best regards, Filip Navara