From: Filip Navara <filip.navara@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs
Date: Tue, 23 Jun 2009 22:21:28 +0200 [thread overview]
Message-ID: <5b31733c0906231321x526bb0dv8cd639604e0f13ca@mail.gmail.com> (raw)
In-Reply-To: <20090623182622.GA5804@lst.de>
On Tue, Jun 23, 2009 at 8:26 PM, Christoph Hellwig<hch@lst.de> wrote:
> On Tue, Jun 23, 2009 at 07:57:01PM +0300, Avi Kivity wrote:
>> >I think not having the state of the private acb area cleared over a
>> >free/realloc cycle is pretty dangerous. Wouldn't it be better to always
>> >clear that space in qemu_aio_get?
>> >
>>
>> Maybe, but that's a bigger change. Let's start with this (in stable-
>> too) and rework aio later.
>
> It's actually smaller - half the size to be exact :)
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
This one solves the issues on Win32 as well. I have no preference for
either patch as long as one of them is applied.
Best regards,
Filip Navara
next prev parent reply other threads:[~2009-06-23 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 13:20 [Qemu-devel] [PATCH] block: Clean up after deleting BHs Avi Kivity
2009-06-23 13:37 ` Filip Navara
2009-06-23 16:50 ` Christoph Hellwig
2009-06-23 16:57 ` Avi Kivity
2009-06-23 18:08 ` Filip Navara
2009-06-23 18:11 ` Avi Kivity
2009-06-23 18:26 ` Christoph Hellwig
2009-06-23 18:31 ` Avi Kivity
2009-06-23 19:41 ` Christoph Hellwig
2009-06-23 19:50 ` Avi Kivity
2009-06-23 20:21 ` Filip Navara [this message]
2009-06-24 18:31 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b31733c0906231321x526bb0dv8cd639604e0f13ca@mail.gmail.com \
--to=filip.navara@gmail.com \
--cc=avi@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).