From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJTYG-0004Wy-VV
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 10:34:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJTYC-0004Pu-5o
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 10:34:16 -0400
Received: from [199.232.76.173] (port=41781 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJTYB-0004PV-NM
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 10:34:11 -0400
Received: from mail-ew0-f211.google.com ([209.85.219.211]:45585)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1MJTYB-0002mj-BE
	for qemu-devel@nongnu.org; Wed, 24 Jun 2009 10:34:11 -0400
Received: by ewy7 with SMTP id 7so1146199ewy.34
	for <qemu-devel@nongnu.org>; Wed, 24 Jun 2009 07:34:10 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090624124230.29402.75964.stgit@mchn012c.ww002.siemens.net>
References: <20090624124227.29402.750.stgit@mchn012c.ww002.siemens.net>
	<20090624124230.29402.75964.stgit@mchn012c.ww002.siemens.net>
Date: Wed, 24 Jun 2009 16:34:10 +0200
Message-ID: <5b31733c0906240734t3ae09c99u792e074489500f59@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 25/41] slirp: Make IP packet ID consistent
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Mark McLoughlin <markmc@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Wed, Jun 24, 2009 at 2:42 PM, Jan Kiszka<jan.kiszka@siemens.com> wrote:
> Currently, ip_id is always initialized to 0 on slirp startup (despite
> the broken attempt to derive it from the clock). This is good for
> reproducibility. But it is not preserved across save/restore. This patch
> therefore drops the dead initialization code from ip_init and introduces
> ip_id to the persistent slirp state.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> =A0slirp/ip_input.c | =A0 =A01 -
> =A0slirp/slirp.c =A0 =A0| =A0 =A08 +++++++-
> =A02 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/slirp/ip_input.c b/slirp/ip_input.c
> index 0356eb5..b07d3d5 100644
> --- a/slirp/ip_input.c
> +++ b/slirp/ip_input.c
> @@ -59,7 +59,6 @@ void
> =A0ip_init(void)
> =A0{
> =A0 =A0 =A0 =A0ipq.ip_link.next =3D ipq.ip_link.prev =3D &ipq.ip_link;
> - =A0 =A0 =A0 ip_id =3D tt.tv_sec & 0xffff;

You removed the ip_id initialization and now it's never initialized in
the code. That sounds wrong.

Best regards,
Filip Navara