From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJWPb-0000e0-3D for qemu-devel@nongnu.org; Wed, 24 Jun 2009 13:37:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJWPV-0000WA-Jo for qemu-devel@nongnu.org; Wed, 24 Jun 2009 13:37:29 -0400 Received: from [199.232.76.173] (port=48176 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJWPV-0000Vz-D4 for qemu-devel@nongnu.org; Wed, 24 Jun 2009 13:37:25 -0400 Received: from mail-ew0-f211.google.com ([209.85.219.211]:55073) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJWPU-00072j-TA for qemu-devel@nongnu.org; Wed, 24 Jun 2009 13:37:25 -0400 Received: by ewy7 with SMTP id 7so1318332ewy.34 for ; Wed, 24 Jun 2009 10:37:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4A41F7EC.2000305@redhat.com> References: <1245707277-769-1-git-send-email-andre.przywara@amd.com> <4A41F7EC.2000305@redhat.com> Date: Wed, 24 Jun 2009 19:37:23 +0200 Message-ID: <5b31733c0906241037t54706611w19eeb2f27f8e63f3@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [PATCH 2/2] introduce -cpu host target From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Andre Przywara , aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On Wed, Jun 24, 2009 at 11:54 AM, Avi Kivity wrote: > On 06/23/2009 12:47 AM, Andre Przywara wrote: >> >> Should we ignore unhandled MSRs like QEMU or Xen do? >> > > Ignoring unhandled msrs is dangerous. =A0If a write has some effect the g= uest > depends on, and we're not emulating that effect, the guest will fail. > =A0Similarly if you don't know what a register mean, who knows what retur= ning > zero for a read will do. It is definitely a bad idea to ignore unknown MSRs. Kernel patch protection scheme used by certain operating system depend on them to work properly and it's pretty hard to debug when you don't know what failed (the MSR read in this case). http://www.uninformed.org/?v=3D3&a=3D3 http://www.uninformed.org/?v=3D6&a=3D1 http://www.uninformed.org/?v=3D8&a=3D5 http://en.wikipedia.org/wiki/Kernel_Patch_Protection Best regards, Filip Navara