From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJXgj-0005Kq-UY for qemu-devel@nongnu.org; Wed, 24 Jun 2009 14:59:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJXgf-0005IW-9F for qemu-devel@nongnu.org; Wed, 24 Jun 2009 14:59:17 -0400 Received: from [199.232.76.173] (port=40971 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJXgf-0005IK-0x for qemu-devel@nongnu.org; Wed, 24 Jun 2009 14:59:13 -0400 Received: from mail-ew0-f211.google.com ([209.85.219.211]:62545) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJXge-0000zv-7c for qemu-devel@nongnu.org; Wed, 24 Jun 2009 14:59:12 -0400 Received: by ewy7 with SMTP id 7so1390168ewy.34 for ; Wed, 24 Jun 2009 11:59:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <4A3D3189.1080307@redhat.com> <10665282192-BeMail@laptop> <20090620232508.GA29958@shareable.org> <7B46D10B-ECDB-4AB7-B9CD-59F7A92886BE@web.de> <20090624182507.GL14121@shareable.org> Date: Wed, 24 Jun 2009 20:59:11 +0200 Message-ID: <5b31733c0906241159j57fcea05vad21db3a29e32935@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: programmingkidx@gmail.com, =?ISO-8859-1?Q?Fran=E7ois_Revol?= , Avi Kivity , qemu-devel@nongnu.org On Wed, Jun 24, 2009 at 8:54 PM, Andreas F=E4rber w= rote: > > Am 24.06.2009 um 20:25 schrieb Jamie Lokier: > >> Andreas F=E4rber wrote: >>> >>> Am 21.06.2009 um 01:25 schrieb Jamie Lokier: >>> >>>> Fran=E7ois Revol wrote: >>>>>> >>>>>> On 06/20/2009 05:31 PM, Anthony Liguori wrote: >>>>>>> >>>>>>> Please [...] use C-style comments instead >>>>>>> of C++ style comments. [...] >>>>>> >>>>>> What do we have against C++ style comments? >>>>> >>>>> They are not valid in C code :P >>>> >>>> Wrong. >>>> >>>> Valid in GNU C for about 14 years, and ANSI/ISO C for about 10 >>>> years... >>>> >>>> I'll be surprised if any C compiler used on any open source operating >>>> system, or any major commercial C compiler, doesn't accept them. >>> >>> Gladly even ten-year-old GCC 2.95.x supports 'em. But even a recent >>> GCC does not when compiled with -ansi, which is why system headers >>> still mustn't use them. >> >> This is wrong too. =A0They can be used in system headers. > > No, that is wrong. freetype2 definitely complained when Haiku had C99 > comments in its POSIX system headers. ;) #pragma GCC system_header Best regards, Filip Navara