From: Filip Navara <filip.navara@gmail.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] sdl zooming
Date: Thu, 2 Jul 2009 16:23:18 +0200 [thread overview]
Message-ID: <5b31733c0907020723x41a91434ladb75b211ae373b2@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0907021502260.27707@kaball-desktop>
On Thu, Jul 2, 2009 at 4:02 PM, Stefano
Stabellini<stefano.stabellini@eu.citrix.com> wrote:
> On Thu, 25 Jun 2009, Stefano Stabellini wrote:
>> Blue Swirl wrote:
>>
>> > On 6/24/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
>> >> Hi all,
>> >> this patch implements zooming capabilities for the sdl interface.
>> >> A new sdl_zoom_blit function is added that is able to scale and blit a
>> >> portion of a surface into another.
>> >> This way we can enable SDL_RESIZABLE and have a real_screen surface with
>> >> a different size than the guest surface and let sdl_zoom_blit take care
>> >> of the problem.
>> >
>> > As you are already using the template system, for extra performance,
>> > you could remove 'smooth' as parameter and instantiate separate
>> > functions for both cases with something like:
>> >
>> > static int glue(glue(sdl_zoom_rgb, BPP), _ ## SMOOTH)(SDL_Surface
>> > *src, SDL_Surface *dst,
>> > SDL_Rect *dst_rect)
>> >
>> > Then s/smooth/SMOOTH/g in the function and adjust callers.
>>
>>
>>
>> I am not sure if this change is going to increase the readability of the
>> code or the performances by much, but this is the new version of the
>> patch nonetheless.
>>
>
> Any update on this?
It was commited to git...
F.
next prev parent reply other threads:[~2009-07-02 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 10:58 [Qemu-devel] [PATCH] sdl zooming Stefano Stabellini
2009-06-24 12:41 ` Anthony Liguori
2009-06-24 14:05 ` Stefano Stabellini
2009-06-24 16:07 ` Blue Swirl
2009-06-25 13:03 ` Stefano Stabellini
2009-07-02 14:02 ` Stefano Stabellini
2009-07-02 14:23 ` Filip Navara [this message]
2009-07-02 14:33 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b31733c0907020723x41a91434ladb75b211ae373b2@mail.gmail.com \
--to=filip.navara@gmail.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).