From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MMNC8-0008WM-Lh
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 10:23:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MMNC4-0008SW-5e
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 10:23:24 -0400
Received: from [199.232.76.173] (port=37987 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MMNC3-0008S2-UM
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 10:23:19 -0400
Received: from mail-ew0-f211.google.com ([209.85.219.211]:63888)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1MMNC3-0001Ea-Jh
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 10:23:19 -0400
Received: by ewy7 with SMTP id 7so1859316ewy.34
	for <qemu-devel@nongnu.org>; Thu, 02 Jul 2009 07:23:18 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.00.0907021502260.27707@kaball-desktop>
References: <4A4206D1.4010002@eu.citrix.com>
	<f43fc5580906240907s2431113bxccd2eb77ad954650@mail.gmail.com>
	<4A4375AA.6060108@eu.citrix.com>
	<alpine.DEB.2.00.0907021502260.27707@kaball-desktop>
Date: Thu, 2 Jul 2009 16:23:18 +0200
Message-ID: <5b31733c0907020723x41a91434ladb75b211ae373b2@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] sdl zooming
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Thu, Jul 2, 2009 at 4:02 PM, Stefano
Stabellini<stefano.stabellini@eu.citrix.com> wrote:
> On Thu, 25 Jun 2009, Stefano Stabellini wrote:
>> Blue Swirl wrote:
>>
>> > On 6/24/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrot=
e:
>> >> Hi all,
>> >> =A0this patch implements zooming capabilities for the sdl interface.
>> >> =A0A new sdl_zoom_blit function is added that is able to scale and bl=
it a
>> >> =A0portion of a surface into another.
>> >> =A0This way we can enable SDL_RESIZABLE and have a real_screen surfac=
e with
>> >> =A0a different size than the guest surface and let sdl_zoom_blit take=
 care
>> >> =A0of the problem.
>> >
>> > As you are already using the template system, for extra performance,
>> > you could remove 'smooth' as parameter and instantiate separate
>> > functions for both cases with something like:
>> >
>> > static int glue(glue(sdl_zoom_rgb, BPP), _ ## SMOOTH)(SDL_Surface
>> > *src, SDL_Surface *dst,
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0SDL_Rect *dst_rect)
>> >
>> > Then s/smooth/SMOOTH/g in the function and adjust callers.
>>
>>
>>
>> I am not sure if this change is going to increase the readability of the
>> code or the performances by much, but this is the new version of the
>> patch nonetheless.
>>
>
> Any update on this?

It was commited to git...

F.