* [Qemu-devel] Re: [COMMIT 379f669] Userspace guest address offsetting
[not found] <200907171219.n6HCJOOJ013182@d01av03.pok.ibm.com>
@ 2009-07-17 18:11 ` Juan Quintela
2009-07-17 18:24 ` Filip Navara
0 siblings, 1 reply; 2+ messages in thread
From: Juan Quintela @ 2009-07-17 18:11 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Paul Brook
Anthony Liguori <aliguori@us.ibm.com> wrote:
> From: Paul Brook <paul@codesourcery.com>
>
> Re-implement GUEST_BASE support.
> Offset guest ddress space by default if the guest binary contains
> regions below the host mmap_min_addr.
> Implement support for i386, x86-64 and arm hosts.
>
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Paul Brook <paul@codesourcery.com>
Hi
I need this patch to be able to crosscompile for windows.
No, I don't know if it is correct, but for the context it looks like
this is the intent.
Paul?
Signed-off-by: Juan Quintela <quintela@redhat.com>
diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
index ed61780..a95fe4c 100644
--- a/tcg/i386/tcg-target.c
+++ b/tcg/i386/tcg-target.c
@@ -624,7 +624,7 @@ static void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args,
}
if (!bswap) {
tcg_out_modrm_offset(s, 0x8b, data_reg, r0, GUEST_BASE);
- tcg_out_modrm_offset(s, 0x8b, data_reg2, r0, GUEST+BASE + 4);
+ tcg_out_modrm_offset(s, 0x8b, data_reg2, r0, GUEST_BASE + 4);
} else {
tcg_out_modrm_offset(s, 0x8b, data_reg, r0, GUEST_BASE + 4);
tcg_out_opc(s, (0xc8 + data_reg) | P_EXT);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] Re: [COMMIT 379f669] Userspace guest address offsetting
2009-07-17 18:11 ` [Qemu-devel] Re: [COMMIT 379f669] Userspace guest address offsetting Juan Quintela
@ 2009-07-17 18:24 ` Filip Navara
0 siblings, 0 replies; 2+ messages in thread
From: Filip Navara @ 2009-07-17 18:24 UTC (permalink / raw)
To: Juan Quintela; +Cc: Anthony Liguori, qemu-devel, Paul Brook
On Fri, Jul 17, 2009 at 8:11 PM, Juan Quintela<quintela@redhat.com> wrote:
> Anthony Liguori <aliguori@us.ibm.com> wrote:
>> From: Paul Brook <paul@codesourcery.com>
>>
>> Re-implement GUEST_BASE support.
>> Offset guest ddress space by default if the guest binary contains
>> regions below the host mmap_min_addr.
>> Implement support for i386, x86-64 and arm hosts.
>>
>> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
>> Signed-off-by: Paul Brook <paul@codesourcery.com>
>
> Hi
>
> I need this patch to be able to crosscompile for windows.
> No, I don't know if it is correct, but for the context it looks like
> this is the intent.
>
> Paul?
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
The patch is definitely correct and should be applied.
Acked-by: Filip Navara <filip.navara@gmail.com>
F.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-17 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200907171219.n6HCJOOJ013182@d01av03.pok.ibm.com>
2009-07-17 18:11 ` [Qemu-devel] Re: [COMMIT 379f669] Userspace guest address offsetting Juan Quintela
2009-07-17 18:24 ` Filip Navara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).