* [Qemu-devel] qemu-thread.c:161: error: invalid operands to binary ==
@ 2009-07-19 12:41 Sebastian Herbszt
2009-07-19 12:56 ` Filip Navara
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Herbszt @ 2009-07-19 12:41 UTC (permalink / raw)
To: qemu-devel
qemu-2582cfa0cba4d7efb36cee0ab709af6f5d810adc
$ make
CC qemu-thread.o
qemu-thread.c: In function `qemu_thread_equal':
qemu-thread.c:161: error: invalid operands to binary ==
make: *** [qemu-thread.o] Error 1
gcc version 3.4.5 (mingw32 special)
- Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] qemu-thread.c:161: error: invalid operands to binary ==
2009-07-19 12:41 [Qemu-devel] qemu-thread.c:161: error: invalid operands to binary == Sebastian Herbszt
@ 2009-07-19 12:56 ` Filip Navara
2009-07-19 13:16 ` [Qemu-devel] [PATCH] qemu-thread: use pthread_equal Sebastian Herbszt
0 siblings, 1 reply; 3+ messages in thread
From: Filip Navara @ 2009-07-19 12:56 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: qemu-devel
On Sun, Jul 19, 2009 at 2:41 PM, Sebastian Herbszt<herbszt@gmx.de> wrote:
> qemu-2582cfa0cba4d7efb36cee0ab709af6f5d810adc
>
> $ make
> CC qemu-thread.o
> qemu-thread.c: In function `qemu_thread_equal':
> qemu-thread.c:161: error: invalid operands to binary ==
> make: *** [qemu-thread.o] Error 1
>
> gcc version 3.4.5 (mingw32 special)
>
> - Sebastian
pthread_equal should be used there.
F.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] qemu-thread: use pthread_equal
2009-07-19 12:56 ` Filip Navara
@ 2009-07-19 13:16 ` Sebastian Herbszt
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Herbszt @ 2009-07-19 13:16 UTC (permalink / raw)
To: qemu-devel
Fixes
qemu-thread.c: In function `qemu_thread_equal':
qemu-thread.c:161: error: invalid operands to binary ==
Use of pthread_equal suggested by Filip Navara.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
--- qemu-2582/qemu-thread.c.orig Sun Jul 19 11:50:49 2009
+++ qemu-2582/qemu-thread.c Sun Jul 19 13:02:11 2009
@@ -158,6 +158,6 @@
int qemu_thread_equal(QemuThread *thread1, QemuThread *thread2)
{
- return (thread1->thread == thread2->thread);
+ return pthread_equal(thread1->thread, thread2->thread);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-19 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-19 12:41 [Qemu-devel] qemu-thread.c:161: error: invalid operands to binary == Sebastian Herbszt
2009-07-19 12:56 ` Filip Navara
2009-07-19 13:16 ` [Qemu-devel] [PATCH] qemu-thread: use pthread_equal Sebastian Herbszt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).