From: Filip Navara <filip.navara@gmail.com>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation.
Date: Thu, 23 Jul 2009 22:28:52 +0200 [thread overview]
Message-ID: <5b31733c0907231328j29463b8fu8b1e8f6bae2fd819@mail.gmail.com> (raw)
In-Reply-To: <20090723201006.GA29483@miranda.arrow>
On Thu, Jul 23, 2009 at 10:10 PM, Stuart Brady<sdbrady@ntlworld.com> wrote:
> + dest = args[0];
> + src = args[1];
> + if (const_temps[src]) {
> + const_temps[dest] = 1;
> + dest_val = ~temp_values[src];
> + *opc_ptr = INDEX_op_movi_i32;
>
> Hrm... is it really right to be setting *opc_ptr = INDEX_op_movi_i32
> even for 64-bit ops? Applies to both 'not'[0] and the binary ops...
You are right, another bug :) I wish I could test it on some 64-bit
target, but QEMU is not working on MinGW64 (unsigned long !=
intptr_t).
Thanks,
Filip Navara
next prev parent reply other threads:[~2009-07-23 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 14:37 [Qemu-devel] [PATCH] RFC: TCG constant propagation Filip Navara
2009-07-23 9:08 ` Filip Navara
2009-07-23 9:25 ` Laurent Desnogues
2009-07-23 9:30 ` Paul Brook
2009-07-23 9:49 ` Filip Navara
2009-07-23 20:10 ` Stuart Brady
2009-07-23 20:28 ` Filip Navara [this message]
2009-07-23 22:02 ` Daniel Jacobowitz
2009-08-05 8:13 ` Pablo Virolainen
2009-08-05 8:48 ` Filip Navara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b31733c0907231328j29463b8fu8b1e8f6bae2fd819@mail.gmail.com \
--to=filip.navara@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sdbrady@ntlworld.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).