From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MU4uQ-0002Sx-VU
	for qemu-devel@nongnu.org; Thu, 23 Jul 2009 16:28:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MU4uM-0002Pv-B2
	for qemu-devel@nongnu.org; Thu, 23 Jul 2009 16:28:58 -0400
Received: from [199.232.76.173] (port=54675 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MU4uM-0002Po-4p
	for qemu-devel@nongnu.org; Thu, 23 Jul 2009 16:28:54 -0400
Received: from mail-ew0-f217.google.com ([209.85.219.217]:65224)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1MU4uL-0002mQ-Lk
	for qemu-devel@nongnu.org; Thu, 23 Jul 2009 16:28:53 -0400
Received: by ewy17 with SMTP id 17so1256101ewy.34
	for <qemu-devel@nongnu.org>; Thu, 23 Jul 2009 13:28:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090723201006.GA29483@miranda.arrow>
References: <E1MTGSg-0007wd-QX@lists.gnu.org>
	<5b31733c0907230208o7374ad68uf6e4438a5c5a41d5@mail.gmail.com>
	<20090723201006.GA29483@miranda.arrow>
Date: Thu, 23 Jul 2009 22:28:52 +0200
Message-ID: <5b31733c0907231328j29463b8fu8b1e8f6bae2fd819@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation.
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org

On Thu, Jul 23, 2009 at 10:10 PM, Stuart Brady<sdbrady@ntlworld.com> wrote:
> + =A0 =A0 =A0 =A0 =A0 =A0dest =3D args[0];
> + =A0 =A0 =A0 =A0 =A0 =A0src =3D args[1];
> + =A0 =A0 =A0 =A0 =A0 =A0if (const_temps[src]) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0const_temps[dest] =3D 1;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0dest_val =3D ~temp_values[src];
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*opc_ptr =3D INDEX_op_movi_i32;
>
> Hrm... is it really right to be setting *opc_ptr =3D INDEX_op_movi_i32
> even for 64-bit ops? =A0Applies to both 'not'[0] and the binary ops...

You are right, another bug :) I wish I could test it on some 64-bit
target, but QEMU is not working on MinGW64 (unsigned long !=3D
intptr_t).

Thanks,
Filip Navara