From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVQKI-0002dn-79
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:33:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVQKD-0002d4-R0
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:33:13 -0400
Received: from [199.232.76.173] (port=38001 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVQKD-0002d1-LD
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:33:09 -0400
Received: from mail-ew0-f217.google.com ([209.85.219.217]:64903)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1MVQKD-0008R5-AW
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:33:09 -0400
Received: by ewy17 with SMTP id 17so3108216ewy.34
	for <qemu-devel@nongnu.org>; Mon, 27 Jul 2009 06:33:08 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090727132123.GA2428@caradoc.them.org>
References: <E1MVL9t-0001cm-94@lists.gnu.org>
	<20090727132123.GA2428@caradoc.them.org>
Date: Mon, 27 Jul 2009 15:33:08 +0200
Message-ID: <5b31733c0907270633xb49d83we1858a6e9ba45d63@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] Remove setvbuf(<handle>, NULL, _IOLBF,
	0) calls for Win32
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Daniel Jacobowitz <drow@false.org>
Cc: qemu-devel@nongnu.org

On Mon, Jul 27, 2009 at 3:21 PM, Daniel Jacobowitz<drow@false.org> wrote:
> On Mon, Jul 27, 2009 at 10:02:04AM +0000, Filip Navara wrote:
>> On Win32 the setvbuf function requires the last parameter to be size bet=
ween 2 and INT_MAX bytes, so the calls always failed. Since the whole point=
 of the calls is to set line-buffered mode for the file handle and that's n=
ot supported on Win32 anyway, conditionally remove them.
>
> Should they be unbuffered where _IOLBF is not supported, then? =A0I
> assume the line buffering was to make them more useful in event of a
> crash.

I guess your assumption is correct. I'd be fine with using _IONBF for
the exec.c part, but setting it for stdout doesn't sound too useful to
me.

Best regards,
Filip Navara