From: Filip Navara <filip.navara@gmail.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] add --accel option
Date: Wed, 29 Jul 2009 00:25:25 +0200 [thread overview]
Message-ID: <5b31733c0907281525h730571b0o9e6c5a460951d9d1@mail.gmail.com> (raw)
In-Reply-To: <1248814081-7860-1-git-send-email-glommer@redhat.com>
On Tue, Jul 28, 2009 at 10:48 PM, Glauber Costa<glommer@redhat.com> wrote:
[snip]
> @@ -3091,7 +3091,6 @@ static int ram_save_live(QEMUFile *f, int stage, void *opaque)
> while (ram_save_block(f) != 0) {
> bytes_transferred += TARGET_PAGE_SIZE;
> }
> - cpu_physical_memory_set_dirty_tracking(0);
> }
>
> qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
This change shouldn't be part of the patch. Otherwise it looks ok.
Best regards,
Filip Navara
next prev parent reply other threads:[~2009-07-28 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 20:48 [Qemu-devel] [PATCH] add --accel option Glauber Costa
2009-07-28 22:25 ` Filip Navara [this message]
2009-07-29 8:16 ` Kevin Wolf
2009-07-29 15:46 ` Glauber Costa
2009-07-29 15:46 ` Kevin Wolf
[not found] ` <m363db5vzj.fsf@neno.mitica>
2009-07-29 15:56 ` [Qemu-devel] " Kevin Wolf
2009-07-29 18:52 ` [Qemu-devel] " Paul Brook
2009-07-29 19:04 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2009-07-28 20:26 Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b31733c0907281525h730571b0o9e6c5a460951d9d1@mail.gmail.com \
--to=filip.navara@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).