From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVv6y-00087q-Jh
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:25:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVv6t-00086g-Fl
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:25:31 -0400
Received: from [199.232.76.173] (port=50440 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVv6t-00086X-7N
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:25:27 -0400
Received: from mail-ew0-f225.google.com ([209.85.219.225]:43715)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1MVv6s-0004QK-Ok
	for qemu-devel@nongnu.org; Tue, 28 Jul 2009 18:25:27 -0400
Received: by ewy25 with SMTP id 25so141636ewy.34
	for <qemu-devel@nongnu.org>; Tue, 28 Jul 2009 15:25:25 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1248814081-7860-1-git-send-email-glommer@redhat.com>
References: <1248814081-7860-1-git-send-email-glommer@redhat.com>
Date: Wed, 29 Jul 2009 00:25:25 +0200
Message-ID: <5b31733c0907281525h730571b0o9e6c5a460951d9d1@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] add --accel option
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Tue, Jul 28, 2009 at 10:48 PM, Glauber Costa<glommer@redhat.com> wrote:
[snip]
> @@ -3091,7 +3091,6 @@ static int ram_save_live(QEMUFile *f, int stage, vo=
id *opaque)
> =A0 =A0 =A0 =A0 while (ram_save_block(f) !=3D 0) {
> =A0 =A0 =A0 =A0 =A0 =A0 bytes_transferred +=3D TARGET_PAGE_SIZE;
> =A0 =A0 =A0 =A0 }
> - =A0 =A0 =A0 =A0cpu_physical_memory_set_dirty_tracking(0);
> =A0 =A0 }
>
> =A0 =A0 qemu_put_be64(f, RAM_SAVE_FLAG_EOS);

This change shouldn't be part of the patch. Otherwise it looks ok.

Best regards,
Filip Navara