qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Filip Navara <filip.navara@gmail.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] make windows notice media change
Date: Wed, 29 Jul 2009 16:35:52 +0200	[thread overview]
Message-ID: <5b31733c0907290735u5dd86d86i293f34df4ce09d10@mail.gmail.com> (raw)
In-Reply-To: <20090729135057.GY30449@redhat.com>

On Wed, Jul 29, 2009 at 3:50 PM, Gleb Natapov<gleb@redhat.com> wrote:
[snip]
> @@ -2898,6 +2901,7 @@ static void ide_load(QEMUFile* f, IDEState *s)
>
>     qemu_get_8s(f, &s->sense_key);
>     qemu_get_8s(f, &s->asc);
> +    qemu_get_8s(f, &s->cdrom_changed);
>     /* XXX: if a transfer is pending, we do not save it yet */
>  }
>
> @@ -3219,7 +3223,7 @@ static int pci_ide_load(QEMUFile* f, void *opaque, int version_id)
>     PCIIDEState *d = opaque;
>     int ret, i;
>
> -    if (version_id != 2)
> +    if (version_id != 3)
>         return -EINVAL;
>     ret = pci_device_load(&d->dev, f);
>     if (ret < 0)

Why shouldn't we support loading version 2 snapshots? Afterall that's
why we had the versioning in the first place.

F.

  parent reply	other threads:[~2009-07-29 14:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29 12:07 [Qemu-devel] [PATCH] make windows notice media change Gleb Natapov
2009-07-29 13:50 ` [Qemu-devel] [PATCH v2] " Gleb Natapov
2009-07-29 14:22   ` Avi Kivity
2009-07-29 14:21     ` Gleb Natapov
2009-07-29 14:44       ` Avi Kivity
2009-07-29 14:35   ` Filip Navara [this message]
2009-07-29 14:40     ` Gleb Natapov
2009-07-29 14:59       ` Stefano Stabellini
2009-07-29 19:11     ` Paul Brook
2009-07-29 19:18       ` Filip Navara
2009-07-29 19:24         ` Filip Navara
2009-07-29 19:34           ` Anthony Liguori
2009-07-29 19:52           ` Paul Brook
2009-07-29 19:56             ` Filip Navara
2009-07-29 20:05               ` Paul Brook
2009-07-29 20:14                 ` Gleb Natapov
2009-07-30 12:14                 ` Stefano Stabellini
2009-07-30 12:27                   ` Paul Brook
2009-07-29 19:33     ` Anthony Liguori
2009-07-29 19:44       ` [Qemu-devel] " Juan Quintela
2009-07-29 20:05         ` Anthony Liguori
2009-07-29 20:09           ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b31733c0907290735u5dd86d86i293f34df4ce09d10@mail.gmail.com \
    --to=filip.navara@gmail.com \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).