From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWAG9-0006De-Gu
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:36:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWAG5-0006C8-QT
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:36:01 -0400
Received: from [199.232.76.173] (port=51440 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWAG5-0006C0-KW
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:35:57 -0400
Received: from mail-ew0-f222.google.com ([209.85.219.222]:61243)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1MWAG5-0005MP-9u
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 10:35:57 -0400
Received: by ewy22 with SMTP id 22so964866ewy.4
	for <qemu-devel@nongnu.org>; Wed, 29 Jul 2009 07:35:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090729135057.GY30449@redhat.com>
References: <20090729120719.GN30449@redhat.com>
	<20090729135057.GY30449@redhat.com>
Date: Wed, 29 Jul 2009 16:35:52 +0200
Message-ID: <5b31733c0907290735u5dd86d86i293f34df4ce09d10@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] make windows notice media change
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Jul 29, 2009 at 3:50 PM, Gleb Natapov<gleb@redhat.com> wrote:
[snip]
> @@ -2898,6 +2901,7 @@ static void ide_load(QEMUFile* f, IDEState *s)
>
> =A0 =A0 qemu_get_8s(f, &s->sense_key);
> =A0 =A0 qemu_get_8s(f, &s->asc);
> + =A0 =A0qemu_get_8s(f, &s->cdrom_changed);
> =A0 =A0 /* XXX: if a transfer is pending, we do not save it yet */
> =A0}
>
> @@ -3219,7 +3223,7 @@ static int pci_ide_load(QEMUFile* f, void *opaque, =
int version_id)
> =A0 =A0 PCIIDEState *d =3D opaque;
> =A0 =A0 int ret, i;
>
> - =A0 =A0if (version_id !=3D 2)
> + =A0 =A0if (version_id !=3D 3)
> =A0 =A0 =A0 =A0 return -EINVAL;
> =A0 =A0 ret =3D pci_device_load(&d->dev, f);
> =A0 =A0 if (ret < 0)

Why shouldn't we support loading version 2 snapshots? Afterall that's
why we had the versioning in the first place.

F.