From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWXLb-0003ZA-Dx
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 11:15:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWXLa-0003XU-MK
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 11:15:10 -0400
Received: from [199.232.76.173] (port=44043 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWXLa-0003XD-9F
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 11:15:10 -0400
Received: from ey-out-1920.google.com ([74.125.78.150]:2145)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1MWXLZ-00040c-VH
	for qemu-devel@nongnu.org; Thu, 30 Jul 2009 11:15:10 -0400
Received: by ey-out-1920.google.com with SMTP id 5so322789eyb.4
	for <qemu-devel@nongnu.org>; Thu, 30 Jul 2009 08:15:08 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4A71B89C.4030803@redhat.com>
References: <1248818713-11261-1-git-send-email-lcapitulino@redhat.com>
	<20090729104600.17deb355@doriath> <4A705536.3020305@redhat.com>
	<20090729112220.16ffe414@doriath> <4A705EAB.1030200@redhat.com>
	<20090729131131.2d5e4fa6@doriath> <4A70769A.7000404@redhat.com>
	<20090730115051.53495100@doriath>
	<5b31733c0907300804n5ccb1c7cla77e193b90718eb6@mail.gmail.com>
	<4A71B89C.4030803@redhat.com>
Date: Thu, 30 Jul 2009 17:15:08 +0200
Message-ID: <5b31733c0907300815i6b7ec420lfa739645eabae93d@mail.gmail.com>
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: aliguori@us.ibm.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On Thu, Jul 30, 2009 at 5:13 PM, Avi Kivity<avi@redhat.com> wrote:
> On 07/30/2009 06:04 PM, Filip Navara wrote:
>>
>> Again, intptr_t should be used here in long term. long is probably
>> fine for now before I post the Win64 patches.
>>
>
> No, for the long term we shouldn't be putting pointers into integers or vice
> versa unless there's a really good reason to do so.

Obviously that's even better. I just meant that "(unsigned) long"
shouldn't be used for pointer casts _where necessary_ and
"(u)intptr_t" should be used instead.

Best regards,
Filip Navara