From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXH6Z-0006nA-6C for qemu-devel@nongnu.org; Sat, 01 Aug 2009 12:06:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXH6U-0006f4-8A for qemu-devel@nongnu.org; Sat, 01 Aug 2009 12:06:42 -0400 Received: from [199.232.76.173] (port=46949 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXH6U-0006en-3v for qemu-devel@nongnu.org; Sat, 01 Aug 2009 12:06:38 -0400 Received: from mail-ew0-f210.google.com ([209.85.219.210]:62411) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXH6T-0007Li-JA for qemu-devel@nongnu.org; Sat, 01 Aug 2009 12:06:37 -0400 Received: by ewy6 with SMTP id 6so319879ewy.34 for ; Sat, 01 Aug 2009 09:06:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <19366128266D400E8F6EBFC3B3A62203@FSCPC> References: <7b74da8ddaa86c684c5d6a2b4743fb52d0383dfa.1248703755.git.quintela@redhat.com> <19366128266D400E8F6EBFC3B3A62203@FSCPC> Date: Sat, 1 Aug 2009 18:06:36 +0200 Message-ID: <5b31733c0908010906j78509098ie60703e22a7bc2b0@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [PATCH 29/47] Use CONFIG_POSIX to simplify Makefile From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Herbszt Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Juan Quintela On Sat, Aug 1, 2009 at 5:54 PM, Sebastian Herbszt wrote: > Juan Quintela wrote: >> >> Signed-off-by: Juan Quintela >> --- >> Makefile | =A0 21 +++++---------------- >> 1 files changed, 5 insertions(+), 16 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 47e5825..a53b630 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -62,21 +62,13 @@ recurse-all: $(SUBDIR_RULES) >> >> block-obj-y =3D cutils.o cache-utils.o qemu-malloc.o qemu-option.o modul= e.o >> block-obj-y +=3D nbd.o block.o aio.o aes.o >> +block-obj-$(CONFIG_AIO) +=3D posix-aio-compat.o >> >> block-nested-y +=3D cow.o qcow.o vmdk.o cloop.o dmg.o bochs.o vpc.o vvfa= t.o >> block-nested-y +=3D qcow2.o qcow2-refcount.o qcow2-cluster.o >> qcow2-snapshot.o >> block-nested-y +=3D parallels.o nbd.o >> - >> - >> -ifdef CONFIG_WIN32 >> -block-nested-y +=3D raw-win32.o >> -else >> -ifdef CONFIG_AIO >> -block-obj-y +=3D posix-aio-compat.o >> -endif >> -block-nested-y +=3D raw-posix.o >> -endif >> - >> +block-nested-$(CONFIG_WIN32) +=3D raw-win32.o >> +block-nested-$(CONFIG_POSIX) +=3D raw-posix.o >> block-nested-$(CONFIG_CURL) +=3D curl.o >> >> block-obj-y +=3D =A0$(addprefix block/, $(block-nested-y)) >> @@ -112,11 +104,8 @@ ifdef CONFIG_BRLAPI >> LIBS+=3D-lbrlapi >> endif >> >> -ifdef CONFIG_WIN32 >> -obj-y +=3D tap-win32.o >> -else >> -obj-y +=3D migration-exec.o >> -endif >> +obj-$(CONFIG_WIN32) +=3D tap-win32.o >> +obj-$(CONFIG_POSIX) +=3D migration-exec.o >> >> ifdef CONFIG_COREAUDIO >> AUDIO_PT =3D y >> -- >> 1.6.2.5 > > I think this patch or a related one breaks MinGW/Win32: > > =A0CC =A0 =A0posix-aio-compat.o > posix-aio-compat.c:14:23: warning: sys/ioctl.h: No such file or directory > posix-aio-compat.c: In function `handle_aiocb_ioctl': > posix-aio-compat.c:90: warning: implicit declaration of function `ioctl' > posix-aio-compat.c: In function `handle_aiocb_rw_linear': > posix-aio-compat.c:182: warning: implicit declaration of function `pwrite= ' > posix-aio-compat.c:187: warning: implicit declaration of function `pread' > posix-aio-compat.c: In function `aio_thread': > posix-aio-compat.c:284: warning: implicit declaration of function > `sigfillset' > posix-aio-compat.c:285: warning: implicit declaration of function > `sigprocmask' > posix-aio-compat.c:332: warning: implicit declaration of function `kill' > posix-aio-compat.c: In function `qemu_paio_submit': > posix-aio-compat.c:367: error: `EINPROGRESS' undeclared (first use in thi= s > function) > posix-aio-compat.c:367: error: (Each undeclared identifier is reported on= ly > once > posix-aio-compat.c:367: error: for each function it appears in.) > posix-aio-compat.c: In function `qemu_paio_cancel': > posix-aio-compat.c:424: error: `ECANCELED' undeclared (first use in this > function) > posix-aio-compat.c:426: error: `EINPROGRESS' undeclared (first use in thi= s > function) > make: *** [posix-aio-compat.o] Error 1 > > v0.11.0-rc0-182-g28e738d on gcc version 3.4.5 (mingw32 special) > > - Sebastian Definitely this one breaks it, posix-aio-compat should be included only when both CONFIG_POSIX and CONFIG_AIO are defined. It's good to see that someone cares about the Win32 build. Best regards, Filip Navara