From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXvRI-00081B-DF for qemu-devel@nongnu.org; Mon, 03 Aug 2009 07:10:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXvRD-00080u-5P for qemu-devel@nongnu.org; Mon, 03 Aug 2009 07:10:47 -0400 Received: from [199.232.76.173] (port=38426 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXvRC-00080r-UR for qemu-devel@nongnu.org; Mon, 03 Aug 2009 07:10:43 -0400 Received: from mx20.gnu.org ([199.232.41.8]:35678) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MXvRC-00076X-IA for qemu-devel@nongnu.org; Mon, 03 Aug 2009 07:10:42 -0400 Received: from mail-ew0-f210.google.com ([209.85.219.210]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXvRA-0005uZ-SQ for qemu-devel@nongnu.org; Mon, 03 Aug 2009 07:10:41 -0400 Received: by ewy6 with SMTP id 6so105720ewy.34 for ; Mon, 03 Aug 2009 04:10:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <7b74da8ddaa86c684c5d6a2b4743fb52d0383dfa.1248703755.git.quintela@redhat.com> <19366128266D400E8F6EBFC3B3A62203@FSCPC> Date: Mon, 3 Aug 2009 13:10:39 +0200 Message-ID: <5b31733c0908030410v379acd15pd1cfc04456d7ed35@mail.gmail.com> Subject: Re: [Qemu-devel] Re: [PATCH 29/47] Use CONFIG_POSIX to simplify Makefile From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Sebastian Herbszt On Mon, Aug 3, 2009 at 10:38 AM, Juan Quintela wrote: > "Sebastian Herbszt" wrote: >> Juan Quintela wrote: > > Hi > > Thanks for the report, on my next series, I add this patch that fix the p= roblem: > >> I think this patch or a related one breaks MinGW/Win32: >> >> =A0CC =A0 =A0posix-aio-compat.o >> posix-aio-compat.c:14:23: warning: sys/ioctl.h: No such file or director= y >> posix-aio-compat.c: In function `handle_aiocb_ioctl': >> posix-aio-compat.c:90: warning: implicit declaration of function `ioctl' >> posix-aio-compat.c: In function `handle_aiocb_rw_linear': >> posix-aio-compat.c:182: warning: implicit declaration of function `pwrit= e' >> posix-aio-compat.c:187: warning: implicit declaration of function `pread= ' >> posix-aio-compat.c: In function `aio_thread': >> posix-aio-compat.c:284: warning: implicit declaration of function `sigfi= llset' >> posix-aio-compat.c:285: warning: implicit declaration of function `sigpr= ocmask' >> posix-aio-compat.c:332: warning: implicit declaration of function `kill' >> posix-aio-compat.c: In function `qemu_paio_submit': >> posix-aio-compat.c:367: error: `EINPROGRESS' undeclared (first use in th= is function) >> posix-aio-compat.c:367: error: (Each undeclared identifier is reported o= nly once >> posix-aio-compat.c:367: error: for each function it appears in.) >> posix-aio-compat.c: In function `qemu_paio_cancel': >> posix-aio-compat.c:424: error: `ECANCELED' undeclared (first use in this= function) >> posix-aio-compat.c:426: error: `EINPROGRESS' undeclared (first use in th= is function) >> make: *** [posix-aio-compat.o] Error 1 >> >> v0.11.0-rc0-182-g28e738d on gcc version 3.4.5 (mingw32 special) >> >> - Sebastian > > From 53e6f57abb0534b5f654dd1b18183c18443ecb5b Mon Sep 17 00:00:00 2001 > From: Juan Quintela > Date: Mon, 3 Aug 2009 10:36:09 +0200 > Subject: [PATCH] disable aio with mingw32 > > > Signed-off-by: Juan Quintela > --- > =A0configure | =A0 =A01 + > =A01 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index 58a32a7..a25343a 100755 > --- a/configure > +++ b/configure > @@ -359,6 +359,7 @@ if test "$mingw32" =3D "yes" ; then > =A0 EXESUF=3D".exe" > =A0 CFLAGS=3D"-DWIN32_LEAN_AND_MEAN -DWINVER=3D0x501 $CFLAGS" > =A0 LIBS=3D"-lwinmm -lws2_32 -liphlpapi $LIBS" > + =A0aio=3Dno > =A0fi > > =A0# find source path I don't think this is the correct way to fix it in long term or at least the variables have to be renamed to something like CONFIG_POSIX_AIO / posix_aio. There's no reason why AIO can't be added to Win32 port and it surely won't use the posix-aio-compat file. Best regards, Filip Navara