From: Filip Navara <filip.navara@gmail.com>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Work around stdio redirection by SDL on Windows
Date: Sun, 9 Aug 2009 14:26:54 +0200 [thread overview]
Message-ID: <5b31733c0908090526w6594523dvff8b6cbce3f80277@mail.gmail.com> (raw)
In-Reply-To: <CB9C1DB604194FD4B20F3055C9363217@FSCPC>
On Sun, Aug 9, 2009 at 2:06 PM, Sebastian Herbszt<herbszt@gmx.de> wrote:
> Work around no longer working console output with SDL on Windows.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>
> --- v0.11.0-rc0-201-gd9c3231/vl.c.orig Sun Aug 9 11:52:47 2009
> +++ v0.11.0-rc0-201-gd9c3231/vl.c Sun Aug 9 11:58:59 2009
> @@ -4873,6 +4873,12 @@
> CPUState *env;
> int show_vnc_port = 0;
>
> +/* Work around stdio redirection by SDL on Windows */
> +#if defined (CONFIG_SDL) && defined (_WIN32)
> + freopen("CON", "wb", stdout);
> + freopen("CON", "wb", stderr);
> +#endif
> +
That will not work in RXVT, SSH consoles and for pipes unfortunately
:-/ Also it won't respect the redirections specified on command line,
which is something I often use, therefore I object to this patch. It's
better to use SDL compiled with the --enable-stdio-redirect=no option.
Best regards,
Filip Navara
next prev parent reply other threads:[~2009-08-09 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-09 12:06 [Qemu-devel] [PATCH] Work around stdio redirection by SDL on Windows Sebastian Herbszt
2009-08-09 12:26 ` Filip Navara [this message]
2009-08-09 22:00 ` [Qemu-devel] " Sebastian Herbszt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b31733c0908090526w6594523dvff8b6cbce3f80277@mail.gmail.com \
--to=filip.navara@gmail.com \
--cc=herbszt@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).