From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ma7UK-0004pD-EB
	for qemu-devel@nongnu.org; Sun, 09 Aug 2009 08:27:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ma7UG-0004om-Uk
	for qemu-devel@nongnu.org; Sun, 09 Aug 2009 08:27:00 -0400
Received: from [199.232.76.173] (port=52094 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ma7UG-0004og-MH
	for qemu-devel@nongnu.org; Sun, 09 Aug 2009 08:26:56 -0400
Received: from mail-ew0-f210.google.com ([209.85.219.210]:56105)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1Ma7UG-0005Qs-BS
	for qemu-devel@nongnu.org; Sun, 09 Aug 2009 08:26:56 -0400
Received: by ewy6 with SMTP id 6so664447ewy.34
	for <qemu-devel@nongnu.org>; Sun, 09 Aug 2009 05:26:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CB9C1DB604194FD4B20F3055C9363217@FSCPC>
References: <CB9C1DB604194FD4B20F3055C9363217@FSCPC>
Date: Sun, 9 Aug 2009 14:26:54 +0200
Message-ID: <5b31733c0908090526w6594523dvff8b6cbce3f80277@mail.gmail.com>
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] Work around stdio redirection by SDL on
	Windows
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org

On Sun, Aug 9, 2009 at 2:06 PM, Sebastian Herbszt<herbszt@gmx.de> wrote:
> Work around no longer working console output with SDL on Windows.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>
> --- v0.11.0-rc0-201-gd9c3231/vl.c.orig Sun Aug =A09 11:52:47 2009
> +++ v0.11.0-rc0-201-gd9c3231/vl.c Sun Aug =A09 11:58:59 2009
> @@ -4873,6 +4873,12 @@
> =A0 =A0CPUState *env;
> =A0 =A0int show_vnc_port =3D 0;
>
> +/* Work around stdio redirection by SDL on Windows */
> +#if defined (CONFIG_SDL) && defined (_WIN32)
> + =A0 =A0freopen("CON", "wb", stdout);
> + =A0 =A0freopen("CON", "wb", stderr);
> +#endif
> +

That will not work in RXVT, SSH consoles and for pipes unfortunately
:-/ Also it won't respect the redirections specified on command line,
which is something I often use, therefore I object to this patch. It's
better to use SDL compiled with the --enable-stdio-redirect=3Dno option.

Best regards,
Filip Navara