From: Filip Navara <filip.navara@gmail.com>
To: Benoit Canet <benoit.canet@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] Make musicpal.c use the generic bitbang I2C device
Date: Mon, 10 Aug 2009 21:47:20 +0200 [thread overview]
Message-ID: <5b31733c0908101247x3c3a2b40x281edad4979c9ba1@mail.gmail.com> (raw)
In-Reply-To: <1249930888-22022-4-git-send-email-benoit.canet@gmail.com>
On Mon, Aug 10, 2009 at 9:01 PM, Benoit Canet<benoit.canet@gmail.com> wrote:
>
> Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
I'd prefer the wm8750 audio emulation to be extracted to separate file
and included as separate patch, much like you did with the bitbang_i2c
device. This device is not really musicpal specific.
Best regards,
Filip Navara
prev parent reply other threads:[~2009-08-10 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 19:01 [Qemu-devel] Review : Musicpal qdev conversion and I2C bitbanging extraction Benoit Canet
2009-08-10 19:01 ` [Qemu-devel] [PATCH 1/3] Musicpal qdev conversion : gpio (except I2C part), keyboard and lcd Benoit Canet
2009-08-10 19:01 ` [Qemu-devel] [PATCH 2/3] Extract musicpal.c I2C bitbanging code and make it gpio aware Benoit Canet
2009-08-10 19:01 ` [Qemu-devel] [PATCH 3/3] Make musicpal.c use the generic bitbang I2C device Benoit Canet
2009-08-10 19:47 ` Filip Navara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b31733c0908101247x3c3a2b40x281edad4979c9ba1@mail.gmail.com \
--to=filip.navara@gmail.com \
--cc=benoit.canet@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).