From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Maaq6-0007bw-KO
	for qemu-devel@nongnu.org; Mon, 10 Aug 2009 15:47:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Maaq2-0007YC-Tu
	for qemu-devel@nongnu.org; Mon, 10 Aug 2009 15:47:26 -0400
Received: from [199.232.76.173] (port=54808 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Maaq2-0007Y9-Rv
	for qemu-devel@nongnu.org; Mon, 10 Aug 2009 15:47:22 -0400
Received: from mail-fx0-f207.google.com ([209.85.220.207]:59360)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <filip.navara@gmail.com>) id 1Maaq2-0007mD-C9
	for qemu-devel@nongnu.org; Mon, 10 Aug 2009 15:47:22 -0400
Received: by fxm3 with SMTP id 3so63356fxm.8
	for <qemu-devel@nongnu.org>; Mon, 10 Aug 2009 12:47:20 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1249930888-22022-4-git-send-email-benoit.canet@gmail.com>
References: <1249930888-22022-1-git-send-email-benoit.canet@gmail.com>
	<1249930888-22022-2-git-send-email-benoit.canet@gmail.com>
	<1249930888-22022-3-git-send-email-benoit.canet@gmail.com>
	<1249930888-22022-4-git-send-email-benoit.canet@gmail.com>
Date: Mon, 10 Aug 2009 21:47:20 +0200
Message-ID: <5b31733c0908101247x3c3a2b40x281edad4979c9ba1@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] Make musicpal.c use the generic bitbang
	I2C device
From: Filip Navara <filip.navara@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benoit Canet <benoit.canet@gmail.com>
Cc: qemu-devel@nongnu.org

On Mon, Aug 10, 2009 at 9:01 PM, Benoit Canet<benoit.canet@gmail.com> wrote:
>
> Signed-off-by: Benoit Canet <benoit.canet@gmail.com>

I'd prefer the wm8750 audio emulation to be extracted to separate file
and included as separate patch, much like you did with the bitbang_i2c
device. This device is not really musicpal specific.

Best regards,
Filip Navara