From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MadTv-0005V9-A7 for qemu-devel@nongnu.org; Mon, 10 Aug 2009 18:36:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MadTu-0005Tg-Cx for qemu-devel@nongnu.org; Mon, 10 Aug 2009 18:36:42 -0400 Received: from [199.232.76.173] (port=45870 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MadTu-0005TM-9A for qemu-devel@nongnu.org; Mon, 10 Aug 2009 18:36:42 -0400 Received: from ey-out-1920.google.com ([74.125.78.144]:49292) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MadTt-0006vv-PN for qemu-devel@nongnu.org; Mon, 10 Aug 2009 18:36:42 -0400 Received: by ey-out-1920.google.com with SMTP id 5so779410eyb.4 for ; Mon, 10 Aug 2009 15:36:40 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1249936656-30905-1-git-send-email-froydnj@codesourcery.com> References: <1249936656-30905-1-git-send-email-froydnj@codesourcery.com> Date: Tue, 11 Aug 2009 00:36:40 +0200 Message-ID: <5b31733c0908101536g5d9ed041ld6c7cf415d3bce67@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] cleanup cpu-exec.c, part 0/N: consolidate handle_cpu_signal From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: froydnj@codesourcery.com Cc: qemu-devel@nongnu.org On Mon, Aug 10, 2009 at 10:37 PM, wrote: > From: Nathan Froyd > > handle_cpu_signal is very nearly copy-paste code for each target, with a > few minor variations. =A0This patch sets up appropriate defaults for a > generic handle_cpu_signal and provides overrides for particular targets > that did things differently. =A0Fixing things like the persistent (XXX: > use sigsetjmp) should now become somewhat easier. > > Previous comments on this patch suggest that the "activate soft MMU for > this block" comments refer to defunct functionality. =A0I have removed > such blocks for the appropriate targets in this patch. > > Signed-off-by: Nathan Froyd Acked-by: Filip Navara Thanks for the patch! Best regards, Filip Navara