Re: [Qemu-devel] [PATCH 1/2] [RFC] add emulation of atmel pflash memory

[Filip Navara <filip.navara@gmail.com>]

On Tue, Nov 17, 2009 at 8:17 PM, Evgeniy Dushistov <dushistov@mail.ru> wrote:
> On Tue, Nov 17, 2009 at 10:28:25AM +0100, Filip Navara wrote:
>> Interesting, I have been working on AT91SAM7X implementation. Most of
>> the stuff is in the GIT repository at
>> http://repo.or.cz/w/qemu/navara.git
>>
>> Any way to merge the efforts? I'd love to merge both mine and your
>> patches to the mainline (minus the overlapping parts of the system
>> controller). In fact my patches lack the flash emulation which would
>> be a welcome addition.
>>
>
> I made quick look at
>>http://repo.or.cz/w/qemu/navara.git
>
> Looks good.
>
> I'm going to see, what parts of your code can be reused in
> at91sam9263 implementation, and then republish patches,
> or we can then merge them into your repository.

Good. Thanks.

> About flash, why do you not used existing implementation of
> intel and amd nor flashes (pflash_cfi0[12].c)? I implemented
> atmel nor flash, because of it used on my real board with at91sam9263
> cpu.

I didn't bother implementing the "Bus matrix", memory controller and
the other components needed for the Flash. Since you already
implemented them, having them as QDEV-based code would allow sharing
the code between the at91sam7x and at91sam9263 boards. The interface
is virtually identical on both of these system controllers.

> And another question, why your support of at91sam7x still not merged
> into mainline?

Firstly, I didn't update it for more than two months, so the patches
no longer apply cleanly to mainline. The QDEV interface has changed a
bit since then, but now it is more or less stable. This is something I
am planning to fix soon. Secondly, only few people were interested in
the patches (or AT91 implementation in general) and QEMU maintainers
were busy with other things, so there was no one to review them and
commit them. If we can produce a set of patches and mutually review
them then there's a bigger chance of getting some of them into the
QEMU mainline.

Best regards,
Filip Navara