From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAXu8-0005t9-7S for qemu-devel@nongnu.org; Tue, 17 Nov 2009 18:56:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAXu3-0005rV-6p for qemu-devel@nongnu.org; Tue, 17 Nov 2009 18:56:11 -0500 Received: from [199.232.76.173] (port=50339 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAXu3-0005rS-1R for qemu-devel@nongnu.org; Tue, 17 Nov 2009 18:56:07 -0500 Received: from mail-bw0-f212.google.com ([209.85.218.212]:63085) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NAXu2-0007rA-JY for qemu-devel@nongnu.org; Tue, 17 Nov 2009 18:56:06 -0500 Received: by bwz4 with SMTP id 4so676763bwz.2 for ; Tue, 17 Nov 2009 15:56:05 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20091117191756.GA13844@rain> References: <20091115204705.GA25577@rain> <5b31733c0911170128t13c633c3gf621b10f791e144f@mail.gmail.com> <20091117191756.GA13844@rain> Date: Wed, 18 Nov 2009 00:56:05 +0100 Message-ID: <5b31733c0911171556h3171f9eaid06b87a46d1d8663@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH 1/2] [RFC] add emulation of atmel pflash memory From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Evgeniy Dushistov Cc: qemu-devel@nongnu.org On Tue, Nov 17, 2009 at 8:17 PM, Evgeniy Dushistov wrote: > On Tue, Nov 17, 2009 at 10:28:25AM +0100, Filip Navara wrote: >> Interesting, I have been working on AT91SAM7X implementation. Most of >> the stuff is in the GIT repository at >> http://repo.or.cz/w/qemu/navara.git >> >> Any way to merge the efforts? I'd love to merge both mine and your >> patches to the mainline (minus the overlapping parts of the system >> controller). In fact my patches lack the flash emulation which would >> be a welcome addition. >> > > I made quick look at >>http://repo.or.cz/w/qemu/navara.git > > Looks good. > > I'm going to see, what parts of your code can be reused in > at91sam9263 implementation, and then republish patches, > or we can then merge them into your repository. Good. Thanks. > About flash, why do you not used existing implementation of > intel and amd nor flashes (pflash_cfi0[12].c)? I implemented > atmel nor flash, because of it used on my real board with at91sam9263 > cpu. I didn't bother implementing the "Bus matrix", memory controller and the other components needed for the Flash. Since you already implemented them, having them as QDEV-based code would allow sharing the code between the at91sam7x and at91sam9263 boards. The interface is virtually identical on both of these system controllers. > And another question, why your support of at91sam7x still not merged > into mainline? Firstly, I didn't update it for more than two months, so the patches no longer apply cleanly to mainline. The QDEV interface has changed a bit since then, but now it is more or less stable. This is something I am planning to fix soon. Secondly, only few people were interested in the patches (or AT91 implementation in general) and QEMU maintainers were busy with other things, so there was no one to review them and commit them. If we can produce a set of patches and mutually review them then there's a bigger chance of getting some of them into the QEMU mainline. Best regards, Filip Navara