From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF2Hj-0004uJ-6Y for qemu-devel@nongnu.org; Mon, 30 Nov 2009 04:11:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF2Hd-0004tc-QO for qemu-devel@nongnu.org; Mon, 30 Nov 2009 04:11:05 -0500 Received: from [199.232.76.173] (port=45393 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF2Hd-0004tZ-K7 for qemu-devel@nongnu.org; Mon, 30 Nov 2009 04:11:01 -0500 Received: from mail-bw0-f212.google.com ([209.85.218.212]:63892) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NF2Hd-0003nx-55 for qemu-devel@nongnu.org; Mon, 30 Nov 2009 04:11:01 -0500 Received: by bwz4 with SMTP id 4so2430980bwz.2 for ; Mon, 30 Nov 2009 01:10:56 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <200911291512.47136.rob@landley.net> References: <20091127111731.GA11982@kyllikki.org> <200911290100.41137.rob@landley.net> <5b31733c0911290157r3119fc56rec48df279b469666@mail.gmail.com> <200911291512.47136.rob@landley.net> Date: Mon, 30 Nov 2009 10:10:56 +0100 Message-ID: <5b31733c0911300110v1225ba0eq79a833a9225b4843@mail.gmail.com> Subject: Re: [Qemu-devel] ARM v4t support From: Filip Navara Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rob Landley Cc: Vincent Sanders , qemu-devel@nongnu.org, Paul Brook On Sun, Nov 29, 2009 at 10:12 PM, Rob Landley wrote: > On Sunday 29 November 2009 03:57:37 Filip Navara wrote: >> On Sun, Nov 29, 2009 at 8:00 AM, Rob Landley wrote: >> > On Friday 27 November 2009 05:35:26 Filip Navara wrote: >> >> On Fri, Nov 27, 2009 at 12:17 PM, Vincent Sanders >> > >> > wrote: >> >> > I appear to be unable to take a hint, your silence on this patch in >> >> > the past probably ought to have been a clue. however this will be t= he >> >> > last time I bother to try and get anything merged so you wont have = to >> >> > be disturbed again. >> >> > >> >> > The attached patch adds V4t support to the ARM emulation, its prett= y >> >> > much the same as the last time it was posted. It is correct in >> >> > everything it does to the best of my knowledge however you will as >> >> > usual no doubt find a corner case it does not cover and reject it. >> >> >> >> I have already sent more complete patch for ARM7TDMI emulation: >> >> >> >> http://www.mail-archive.com/qemu-devel@nongnu.org/msg17205.html >> >> http://patchwork.ozlabs.org/patch/36841/ >> > >> > That's a link to an archive that gives you html but not a raw patch. >> > =A0(Huh, it says you sent it to the list but I'm not finding it in my = mail >> > folder. Rummage, rummage, rummage... =A0Ah, your original patch was da= ted >> > December 31 1969.) >> >> Yep, a bug in TortoiseGIT that was later fixed. >> >> > Ok, dug it up, applied it, booted an -M versatilepb kernel built with = an >> > armv4tl compiler that I'm assured works for real armv4tl hardware, and= I >> > get no boot messages if I say "-cpu arm7tdmi", but it boots fine if I >> > don't say that. >> > >> > Let's try my armv4l setup (which I've booted on real armv4tl hardware, >> > albeit with a different kernel .config but qemu hasn't got a board >> > emulation for the Tin Can Tools Hammer, last I checked...) =A0That's a= n >> > OABI which doesn't depend on the Thumb extensions... >> > >> > Nope, that's armv4 OABI, and I've tested the output of that compiler o= n >> > real hardware, albeit with a different kernel .config. >> > >> > Your patch does not work for me. =A0Is there a kernel .config change I= need >> > to do for this? =A0Looking in the kernel kconfig stuff, the only way t= o >> > select arm7tdmi is to disable MMU support. =A0Is this a nommu processo= r? >> > =A0(I know there are armv4t processors _with_ mmu...) >> >> It is nommu processor, so I would be surprised to see any of the >> kernels running. Unfortunately I don't have a ready-to-use kernel >> .config file for it, since I never even tried it with Linux. > > Did you add any armv4t processors with mmu? =A0I believe the actual hardw= are I > tested was an ARM920T. =A0Vincent's patch claims to add arm920T, I tested= yours > because you claimed it was "more complete". No, I didn't. My patch is more complete in the underlying ARM V4 bits, not in the formal definitions of the processor models. Adding ARM920T is matter of adding these two lines to target-arm/cpu.h (as in Vincent's patch): #define ARM_CPUID_ARM920T 0x41129200 { ARM_CPUID_ARM920T, "arm920t"}, and then adding the processor definition into helper.c: case ARM_CPUID_ARM920T: set_feature(env, ARM_FEATURE_ABORT_BU); set_feature(env, ARM_FEATURE_CP15); env->cp15.c0_cachetype =3D 0x0d172172; env->cp15.c1_sys =3D 0x00000078; break; > > I guess I should go test vincent's. > >> > What kernel .config, -M, and -cpu and =A0did you use to test an armv4t >> > system image with your patch? >> >> -M at91pes (which is included in other patches from around the same >> time, but was never merged) > > "Included in other patches"... =A0How _many_ other patches? =A0And how fa= r is > "around"? http://repo.or.cz/w/qemu/navara.git The repository is desperately in need of rebasing, but I still didn't find a time to do so. > If you'd like to resubmit them as a batch, I can try coming up with a ker= nel > .config. =A0(And a uClibc .config since I haven't actually tried a nommu = system > yet.) I'll resubmit them soon and maybe merge some of the AT91SAM9 work, including the ARM920T cpu. Best regards, Filip Navara