From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1c5Cz1-00072K-0V
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 09:39:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1c5Cyx-0005bo-Tr
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 09:39:11 -0500
Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35872)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <rth7680@gmail.com>) id 1c5Cyx-0005bY-NB
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 09:39:07 -0500
Received: by mail-wm0-x244.google.com with SMTP id m203so8239783wma.3
	for <qemu-devel@nongnu.org>; Fri, 11 Nov 2016 06:39:07 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <20161111142018.22567-1-kbastian@mail.uni-paderborn.de>
	<20161111142018.22567-3-kbastian@mail.uni-paderborn.de>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <5b3ad79a-0b9c-40e9-b78c-00bb67c96113@twiddle.net>
Date: Fri, 11 Nov 2016 15:39:02 +0100
MIME-Version: 1.0
In-Reply-To: <20161111142018.22567-3-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/5] target-tricore: Added MADD.F and
 MSUB.F instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org

On 11/11/2016 03:20 PM, Bastian Koppelmann wrote:
> +        if (muladd_negate_c) {
> +            cSign ^= 1;
> +        }
> +        if (((aExp == 0xff) || (bExp == 0xff)) && (cExp == 0xff)) {
> +            if (aSign ^ bSign ^ cSign) {

If you're going to make muladd_negate_c a bool, you might as well just fold 
that in here:

   if (aSign ^ bSign ^ cSign ^ muladd_negate_c)

And, come to think of it,

> +            arg1 = float32_squash_input_denormal(arg1, &env->fp_status);
> +            arg2 = float32_squash_input_denormal(arg2, &env->fp_status);
> +            arg3 = float32_squash_input_denormal(arg3, &env->fp_status);

can be folded into f_maddsub_nan_result as

     } else if (float32_is_infinity(arg1)
                && float32_is_zero(float32_squash_input_denormal
                   (arg2, &env->fp_status))) {
         return MUL_NAN;
     } else if (float32_is_infinity(arg2)
                && float32_is_zero(float32_squash_input_denormal
                   (arg1, &env->fp_status))) {
         return MUL_NAN;

which makes it less likely that the squash will actually be called.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~