* [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size
@ 2018-04-15 20:31 Philippe Mathieu-Daudé
2018-04-16 16:05 ` mar.krzeminski
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-04-15 20:31 UTC (permalink / raw)
To: Marcin Krzemiński, Peter Crosthwaite, Alistair Francis,
Kevin Wolf, Max Reitz
Cc: Philippe Mathieu-Daudé, qemu-devel, qemu-block
>From the datasheet (3368J–SEEPR) description:
The AT25128A/256A provides 131,072/262,144 bits of serial
electrically-erasable programmable read only memory (EEPROM)
organized as 16,384/32,768 words of 8 bits each.
However QEMU models the flash size in bytes.
Correct the at25128a/at25256a entries to reflect the datasheet size.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
This is not a regression, so can now wait for 2.13.
hw/block/m25p80.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index b49c8e9caa..d0b9fbfc50 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -196,8 +196,8 @@ static const FlashPartInfo known_devices[] = {
/* Atmel EEPROMS - it is assumed, that don't care bit in command
* is set to 0. Block protection is not supported.
*/
- { INFO("at25128a-nonjedec", 0x0, 0, 1, 131072, EEPROM) },
- { INFO("at25256a-nonjedec", 0x0, 0, 1, 262144, EEPROM) },
+ { INFO("at25128a-nonjedec", 0x0, 0, 1, 16384, EEPROM) },
+ { INFO("at25256a-nonjedec", 0x0, 0, 1, 32768, EEPROM) },
/* EON -- en25xxx */
{ INFO("en25f32", 0x1c3116, 0, 64 << 10, 64, ER_4K) },
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size
2018-04-15 20:31 [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size Philippe Mathieu-Daudé
@ 2018-04-16 16:05 ` mar.krzeminski
2018-04-16 20:52 ` Alistair Francis
0 siblings, 1 reply; 4+ messages in thread
From: mar.krzeminski @ 2018-04-16 16:05 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Peter Crosthwaite, Alistair Francis,
Kevin Wolf, Max Reitz
Cc: qemu-devel, qemu-block
W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze:
> >From the datasheet (3368J–SEEPR) description:
> The AT25128A/256A provides 131,072/262,144 bits of serial
> electrically-erasable programmable read only memory (EEPROM)
> organized as 16,384/32,768 words of 8 bits each.
>
> However QEMU models the flash size in bytes.
> Correct the at25128a/at25256a entries to reflect the datasheet size.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Marcin Krzeminski <mar.krzeminski@gmail.com>
> ---
> This is not a regression, so can now wait for 2.13.
>
> hw/block/m25p80.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index b49c8e9caa..d0b9fbfc50 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -196,8 +196,8 @@ static const FlashPartInfo known_devices[] = {
> /* Atmel EEPROMS - it is assumed, that don't care bit in command
> * is set to 0. Block protection is not supported.
> */
> - { INFO("at25128a-nonjedec", 0x0, 0, 1, 131072, EEPROM) },
> - { INFO("at25256a-nonjedec", 0x0, 0, 1, 262144, EEPROM) },
> + { INFO("at25128a-nonjedec", 0x0, 0, 1, 16384, EEPROM) },
> + { INFO("at25256a-nonjedec", 0x0, 0, 1, 32768, EEPROM) },
Thanks!
Marcin
>
> /* EON -- en25xxx */
> { INFO("en25f32", 0x1c3116, 0, 64 << 10, 64, ER_4K) },
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size
2018-04-16 16:05 ` mar.krzeminski
@ 2018-04-16 20:52 ` Alistair Francis
2018-05-09 3:50 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Alistair Francis @ 2018-04-16 20:52 UTC (permalink / raw)
To: mar.krzeminski
Cc: Philippe Mathieu-Daudé, Peter Crosthwaite, Alistair Francis,
Kevin Wolf, Max Reitz, qemu-devel@nongnu.org Developers,
Qemu-block
On Mon, Apr 16, 2018 at 9:05 AM, mar.krzeminski
<mar.krzeminski@gmail.com> wrote:
> W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze:
>>
>> >From the datasheet (3368J–SEEPR) description:
>> The AT25128A/256A provides 131,072/262,144 bits of serial
>> electrically-erasable programmable read only memory (EEPROM)
>> organized as 16,384/32,768 words of 8 bits each.
>>
>> However QEMU models the flash size in bytes.
>> Correct the at25128a/at25256a entries to reflect the datasheet size.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Reviewed-by: Marcin Krzeminski <mar.krzeminski@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
>>
>> ---
>> This is not a regression, so can now wait for 2.13.
>>
>> hw/block/m25p80.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
>> index b49c8e9caa..d0b9fbfc50 100644
>> --- a/hw/block/m25p80.c
>> +++ b/hw/block/m25p80.c
>> @@ -196,8 +196,8 @@ static const FlashPartInfo known_devices[] = {
>> /* Atmel EEPROMS - it is assumed, that don't care bit in command
>> * is set to 0. Block protection is not supported.
>> */
>> - { INFO("at25128a-nonjedec", 0x0, 0, 1, 131072, EEPROM) },
>> - { INFO("at25256a-nonjedec", 0x0, 0, 1, 262144, EEPROM) },
>> + { INFO("at25128a-nonjedec", 0x0, 0, 1, 16384, EEPROM) },
>> + { INFO("at25256a-nonjedec", 0x0, 0, 1, 32768, EEPROM) },
>
> Thanks!
> Marcin
>
>> /* EON -- en25xxx */
>> { INFO("en25f32", 0x1c3116, 0, 64 << 10, 64, ER_4K) },
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size
2018-04-16 20:52 ` Alistair Francis
@ 2018-05-09 3:50 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-09 3:50 UTC (permalink / raw)
To: Alistair Francis, mar.krzeminski
Cc: Peter Crosthwaite, Alistair Francis, Kevin Wolf, Max Reitz,
qemu-devel@nongnu.org Developers, Qemu-block
[-- Attachment #1: Type: text/plain, Size: 1916 bytes --]
Hi Peter, Kevin,
On 04/16/2018 05:52 PM, Alistair Francis wrote:
> On Mon, Apr 16, 2018 at 9:05 AM, mar.krzeminski
> <mar.krzeminski@gmail.com> wrote:
>> W dniu 15.04.2018 o 22:31, Philippe Mathieu-Daudé pisze:
>>>
>>> >From the datasheet (3368J–SEEPR) description:
>>> The AT25128A/256A provides 131,072/262,144 bits of serial
>>> electrically-erasable programmable read only memory (EEPROM)
>>> organized as 16,384/32,768 words of 8 bits each.
>>>
>>> However QEMU models the flash size in bytes.
>>> Correct the at25128a/at25256a entries to reflect the datasheet size.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Reviewed-by: Marcin Krzeminski <mar.krzeminski@gmail.com>
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>
> Alistair
>
>>>
>>> ---
>>> This is not a regression, so can now wait for 2.13.
>>>
>>> hw/block/m25p80.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
>>> index b49c8e9caa..d0b9fbfc50 100644
>>> --- a/hw/block/m25p80.c
>>> +++ b/hw/block/m25p80.c
>>> @@ -196,8 +196,8 @@ static const FlashPartInfo known_devices[] = {
>>> /* Atmel EEPROMS - it is assumed, that don't care bit in command
>>> * is set to 0. Block protection is not supported.
>>> */
>>> - { INFO("at25128a-nonjedec", 0x0, 0, 1, 131072, EEPROM) },
>>> - { INFO("at25256a-nonjedec", 0x0, 0, 1, 262144, EEPROM) },
>>> + { INFO("at25128a-nonjedec", 0x0, 0, 1, 16384, EEPROM) },
>>> + { INFO("at25256a-nonjedec", 0x0, 0, 1, 32768, EEPROM) },
>>
>> Thanks!
>> Marcin
>>
>>> /* EON -- en25xxx */
>>> { INFO("en25f32", 0x1c3116, 0, 64 << 10, 64, ER_4K) },
>>
>>
>>
Can this patch goes via the ARM or Block tree?
Thanks,
Phil.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-09 3:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-15 20:31 [Qemu-devel] [PATCH for-2.12?] m25p80: Correct the at25128a/at25256a eeproms size Philippe Mathieu-Daudé
2018-04-16 16:05 ` mar.krzeminski
2018-04-16 20:52 ` Alistair Francis
2018-05-09 3:50 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).