qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Anton Johansson <anjo@rev.ng>,
	Alistair Francis <alistair@alistair23.me>,
	 "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [PATCH 3/5] target/microblaze: Remove target_ulong use in gen_goto_tb()
Date: Wed, 8 Oct 2025 10:31:06 -0700	[thread overview]
Message-ID: <5b420362-f067-4e11-b732-c8a2b9b998e7@linaro.org> (raw)
In-Reply-To: <20251008060129.87579-4-philmd@linaro.org>

On 10/7/25 11:01 PM, Philippe Mathieu-Daudé wrote:
> translator_use_goto_tb() expects a vaddr type since commit
> b1c09220b4c ("accel/tcg: Replace target_ulong with vaddr in
> translator_*()").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/microblaze/translate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index 5098a1db4dc..ff33e64a710 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -116,7 +116,7 @@ static void gen_raise_hw_excp(DisasContext *dc, uint32_t esr_ec)
>       gen_raise_exception_sync(dc, EXCP_HW_EXCP);
>   }
>   
> -static void gen_goto_tb(DisasContext *dc, int n, target_ulong dest)
> +static void gen_goto_tb(DisasContext *dc, int n, vaddr dest)
>   {
>       if (translator_use_goto_tb(&dc->base, dest)) {
>           tcg_gen_goto_tb(n);

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>



  parent reply	other threads:[~2025-10-08 17:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08  6:01 [PATCH 0/5] target/microblaze: Remove all uses of target_ulong type Philippe Mathieu-Daudé
2025-10-08  6:01 ` [PATCH 1/5] target/microblaze: Remove target_ulong use in cpu_handle_mmu_fault() Philippe Mathieu-Daudé
2025-10-08 10:04   ` Anton Johansson via
2025-10-08 17:30   ` Pierrick Bouvier
2025-10-08  6:01 ` [PATCH 2/5] target/microblaze: Remove target_ulong uses in get_phys_page_attrs_debug Philippe Mathieu-Daudé
2025-10-08 17:30   ` Pierrick Bouvier
2025-10-08  6:01 ` [PATCH 3/5] target/microblaze: Remove target_ulong use in gen_goto_tb() Philippe Mathieu-Daudé
2025-10-08 10:07   ` Anton Johansson via
2025-10-08 17:31   ` Pierrick Bouvier [this message]
2025-10-08  6:01 ` [PATCH 4/5] target/microblaze: Remove target_ulong use in helper_stackprot() Philippe Mathieu-Daudé
2025-10-08 10:22   ` Anton Johansson via
2025-10-15 17:39     ` Philippe Mathieu-Daudé
2025-10-08 17:31   ` Pierrick Bouvier
2025-10-08  6:01 ` [PATCH 5/5] target/microblaze: Convert CPUMBState::res_addr field to uint32_t type Philippe Mathieu-Daudé
2025-10-08 10:23   ` Anton Johansson via
2025-10-08 17:31   ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b420362-f067-4e11-b732-c8a2b9b998e7@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alistair@alistair23.me \
    --cc=anjo@rev.ng \
    --cc=edgar.iglesias@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).