From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98695D59D6F for ; Fri, 12 Dec 2025 17:19:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vU6my-0001Z7-Vj; Fri, 12 Dec 2025 12:18:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vU6mw-0001Y3-31 for qemu-devel@nongnu.org; Fri, 12 Dec 2025 12:18:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vU6mu-0001cY-DB for qemu-devel@nongnu.org; Fri, 12 Dec 2025 12:18:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765559918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=skUYhnectFUI9Gm3a6EJUf5JhDI2I7If0E73DYtzgtQ=; b=RR6X4pXEGfBeCuM23pKGRkIooYGHbnOa38B3A50JK/SEsdk/qdhrXWtPD9UF0Poa5J/vNs 9UOYUxdAIygUgMvq4wcpGYWk87XAmU6Tsk2B/9yhdsXFbGJya1RdlZitkeibXsMAAx4nQV 1MSK3/GEtfERmm4ectf9NFI8FL3+27w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-7ViVJUVlNZysLocPuu3PuQ-1; Fri, 12 Dec 2025 12:18:37 -0500 X-MC-Unique: 7ViVJUVlNZysLocPuu3PuQ-1 X-Mimecast-MFC-AGG-ID: 7ViVJUVlNZysLocPuu3PuQ_1765559916 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4775d110fabso9309475e9.1 for ; Fri, 12 Dec 2025 09:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765559916; x=1766164716; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=skUYhnectFUI9Gm3a6EJUf5JhDI2I7If0E73DYtzgtQ=; b=o7nFf4pBlAMMI9u/w4cVK0+7OVsYdeo4u48mMqdABQD7pOkpbwguip9n80wOzP3pli /AMqRM6A7pUhd+t5cvA4t83bnNJ4VjIZxSFvirU/xkxPFXTtNyP2U5+hMVdhqKgPLXzy OYthD6h80h8fInkQkq6TLVNFSS0KYoiBBIwyYArZJnSqHRxTmOJXIwMo1h/Bw0yyDGdm 0BrP7ebWqLYtNC6JBWGl1Ai4q3MLoHnlJDnxqPfaTMF3sa9B58zA8PhUj6QirPa5SXor x008OWX6ifozFTgLOTxLEdvJ9BvcJbOhHAJW1jvgmUePO+5xOi+WDY26uxkntthI5+iK BrKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765559916; x=1766164716; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=skUYhnectFUI9Gm3a6EJUf5JhDI2I7If0E73DYtzgtQ=; b=VV9vSjK2hPFvf6NGaRtdOpdyHU0rRBk2NT5NGOU8HAOMTIari25moMJlzOsfrwyIHD oCzrAN0B3J03XlIvcp5u9NoIcevTKg9688I6Dp5wzTLexyC7QKD7mAIWfSNcHUBXxM/u IxIw+fvNArJy6qMAlBHadO6AvjbJd31aOE0umX02qhPvUdqQbjsnrQi5h1FC3DEXjlFU FoDYhawsJXHFdlZGuH4LtYAGjV6DzOvD22YLCSUj2YZMpAD56G9hwbJdUOwHs+jfcRde CmOETiDS9KJ+FGkc2a1RReGmeE6kgWFZxcPkfejZ8Osot+ubm7Wi17FY+kxPtjYpXNCV 58dg== X-Forwarded-Encrypted: i=1; AJvYcCVi43Recm8Yzzk5yceXNtse5nARqL5tyxCXmQa9KYS53spsdGjLbOueJAnJMhM2J47AZBMVtsSHE+PA@nongnu.org X-Gm-Message-State: AOJu0YwJeZA7G7CUKLUp+DujRQjJTSPO+WYhbVaUnUNaFYywoptolP55 1T7oTwPiiZgp+USVOr0E7JVCyWT5IXMqnNbbMmYu9CTq6wz4SowkYXEzRF+vRVgG+nlCKkUUMzQ sXo0IUHliW03WD7hUfs3Q+to9yNcXSBipZjVYfuLEcRrRpVaqUhyEnsWn X-Gm-Gg: AY/fxX6zgFGbivU6VkamCQC6gMkhusQn5Ba3nhkhukvCvDguwSjLBwb9tYp5RxCqwKl sqzonbvADi9Id8tK2O/eJNodvnRgQme2Lul97Ozh3wFObh1gvcXPWLLWgeILPznTpOuS8mV8dCP bVwXv+ymT9Ezg1FMIoLB5PaX/Q6gQKdC0TziA5xw/F+5+rFGDsAprISoMbJbTe+d+PnFwGBiCYm tJzP38us/C0AGWh7RQDIZ8juF4sMj5YNfGBrpftfVejG7ktcySswIMdPPBAdzPlGjiz6NXgueze Vh5aPjI5sj/g1L5c5rmOP9LTHsS4/L/ojs97tN03eLrX9plLobSN30v6WFh7vTtZjIaaqJEzS4I Z0uAfn3iI9uJSHpRJaA/jhjBwX1iFtePmLKb957Vk/hjY X-Received: by 2002:a05:600c:444a:b0:465:a51d:d4 with SMTP id 5b1f17b1804b1-47a8f8a7570mr28737425e9.6.1765559916092; Fri, 12 Dec 2025 09:18:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGA7S40qfMSVXTFBn33aes1A2mOwQVgNd2kVFXm4NY2dFimcUTbrRz3MTE/78NtAuYuOyxbsg== X-Received: by 2002:a05:600c:444a:b0:465:a51d:d4 with SMTP id 5b1f17b1804b1-47a8f8a7570mr28737225e9.6.1765559915661; Fri, 12 Dec 2025 09:18:35 -0800 (PST) Received: from [192.168.0.5] (ip-109-41-115-194.web.vodafone.de. [109.41.115.194]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f38a4e9sm52446415e9.2.2025.12.12.09.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Dec 2025 09:18:35 -0800 (PST) Message-ID: <5b510f3b-796a-45fb-a63f-e87b02dace61@redhat.com> Date: Fri, 12 Dec 2025 18:18:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] migration: Fix a possible crash when halting a guest during migration To: Fabiano Rosas , Stefan Hajnoczi Cc: Peter Xu , qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Eric Blake , Paolo Bonzini , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Markus Armbruster , Peter Maydell , =?UTF-8?Q?Alex_Benn=C3=A9e?= References: <20251208135101.271417-1-thuth@redhat.com> <20251208144525.GA1341938@fedora> <87jyyxkna0.fsf@suse.de> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <87jyyxkna0.fsf@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 08/12/2025 16.26, Fabiano Rosas wrote: > Stefan Hajnoczi writes: > >> On Mon, Dec 08, 2025 at 02:51:01PM +0100, Thomas Huth wrote: >>> From: Thomas Huth >>> >>> When shutting down a guest that is currently in progress of being >>> migrated, there is a chance that QEMU might crash during bdrv_delete(). >>> The backtrace looks like this: >>> >>> Thread 74 "mig/src/main" received signal SIGSEGV, Segmentation fault. >>> >>> [Switching to Thread 0x3f7de7fc8c0 (LWP 2161436)] >>> 0x000002aa00664012 in bdrv_delete (bs=0x2aa00f875c0) at ../../devel/qemu/block.c:5560 >>> 5560 QTAILQ_REMOVE(&graph_bdrv_states, bs, node_list); >>> (gdb) bt >>> #0 0x000002aa00664012 in bdrv_delete (bs=0x2aa00f875c0) at ../../devel/qemu/block.c:5560 >>> #1 bdrv_unref (bs=0x2aa00f875c0) at ../../devel/qemu/block.c:7170 >>> Backtrace stopped: Cannot access memory at address 0x3f7de7f83e0 >>> > > How does the migration thread reaches here? Is this from > migration_block_inactivate()? Unfortunately, gdb was not very helpful here (claiming that it cannot access the memory and stack anymore), so I had to do some printf debugging. This is what seems to happen: Main thread: qemu_cleanup() calls  migration_shutdown() --> migration_cancel() which signals the migration thread to cancel the migration. Migration thread: migration_thread() got kicked out the loop and calls migration_iteration_finish(), which tries to get the BQL via bql_lock() but that is currently held by another thread, so the migration thread is blocked here. Main thread: qemu_cleanup() advances to bdrv_close_all() that uses blockdev_close_all_bdrv_states() to unref all BDS. The BDS with the name 'libvirt-1-storage' gets deleted via bdrv_delete() that way. Migration thread: Later, migration_iteration_finish() finally gets the BQL, and calls the migration_block_activate() function in the MIGRATION_STATUS_CANCELLING case statement. This calls bdrv_activate_all(). bdrv_activate_all() gets a pointer to that 'libvirt-1-storage' BDS again from bdrv_first(), and during the bdrv_next() that BDS gets unref'ed again which is causing the crash. ==> Why is bdrv_first() still providing a BDS that have been deleted by other threads earlier? >> It sounds like the migration thread does not hold block graph refcounts >> and assumes the BlockDriverStates it uses have a long enough lifetime. >> >> I don't know the migration code well enough to say whether joining in >> migration_shutdown() is okay. Another option would be expicitly holding >> the necessary refcounts in the migration thread. > > I agree. In principle and also because shuffling the joining around > feels like something that's prone to introduce other bugs. I'm a little bit lost here right now ... Can you suggest a place where we would need to increase the refcounts in the migration thread? Thomas