From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5383FC47096 for ; Thu, 3 Jun 2021 08:07:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2716613DA for ; Thu, 3 Jun 2021 08:07:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2716613DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loiNo-0007RG-Nz for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 04:07:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loiN8-0006b0-SS for qemu-devel@nongnu.org; Thu, 03 Jun 2021 04:06:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59085) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loiN6-0005zm-DU for qemu-devel@nongnu.org; Thu, 03 Jun 2021 04:06:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622707591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2CJbSTh8POxmdS/TMrB99mO+3zWUE8iri6WrcVrNREA=; b=iHcwPlL+GaWEMIXymJU9MUeztTRyCRfSuMXtrwJQjnwzt4s95PrXuonqdUKraMw6ImJSDh UGbBRrMVIGhsOMyeDAHZ6a80AJVmX/1o8d8PB8hAN4XVSJ0cMYVwQgOq/wvn56YjG2csx6 K4beQhNOmSMIoBPVtcdehfCX5cxyayc= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-nDT2G7dhM4eadms4dGDbDw-1; Thu, 03 Jun 2021 04:06:29 -0400 X-MC-Unique: nDT2G7dhM4eadms4dGDbDw-1 Received: by mail-ed1-f69.google.com with SMTP id c12-20020aa7d60c0000b029038fccdf4390so2865625edr.9 for ; Thu, 03 Jun 2021 01:06:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2CJbSTh8POxmdS/TMrB99mO+3zWUE8iri6WrcVrNREA=; b=Jcf5bGyHVH1S4OZNfoG0Zy07w2YaIQjcCG1umLtR1dxYjYC+zNm6uF4db/2AykgQMl ENgmGWGgAqDfYBwv9AAzZe7yzIsqnIq4iAWKKpIVjQguRb3xbH+3Pl9nC3IDOnFgd5mn Gl62fTTSgLlwR8OifiG9sWsRPkz0xRuzjTdBg5zkxXjbhMbjDlU4vX/31Uxad/myYEp6 XeSs+MYRTHL7+bI/d8BRwkUi2TKHD4eEXJ4ieIJSPHQP7PkHmrIp3EHCOMuA3/eMVZW8 DVHGAKOCRwkM4as3YrhhSFuJdx/YibY4HDr9yc/iRkyb7dyLyO/NgoVcrTu4zZuUtpdA QLNA== X-Gm-Message-State: AOAM532jTENA7s+tYXMP7q7NWigdM89C7heMiusaQ5jPNWaG1HizRI98 2K8YaFzGhTWEh+eeyv00uzq9KNNXa8GymbL1C7sppmg45PsoHaKZzPcpNp/pcKkbvB2l3KgM8jd 08TWK5WViiJ680kiBU14U+8oZOtS9LTbqTA0NMUT4U3G2aOyY1w5MKOICaiadYuQCAWo= X-Received: by 2002:a17:906:b4b:: with SMTP id v11mr15159036ejg.359.1622707587620; Thu, 03 Jun 2021 01:06:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxchn1Rmu9mHxnsfbxpBdMd+241uBTvydT/w12oKhmpCRXWQN+U5Znovc9GGqopCHUbQAl9Xw== X-Received: by 2002:a17:906:b4b:: with SMTP id v11mr15158997ejg.359.1622707587292; Thu, 03 Jun 2021 01:06:27 -0700 (PDT) Received: from localhost.localdomain ([2a04:ee41:4:31cb:e591:1e1e:abde:a8f1]) by smtp.gmail.com with ESMTPSA id v23sm1348423eds.25.2021.06.03.01.06.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 01:06:26 -0700 (PDT) Subject: Re: [PATCH v4 01/15] python: qemu: add timer parameter for qmp.accept socket To: John Snow , qemu-block@nongnu.org References: <20210520075236.44723-1-eesposit@redhat.com> <20210520075236.44723-2-eesposit@redhat.com> From: Emanuele Giuseppe Esposito Message-ID: <5b53f903-1a11-7dec-fe4c-6dc16c066056@redhat.com> Date: Thu, 3 Jun 2021 10:06:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.613, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-devel@nongnu.org, Max Reitz , Cleber Rosa , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03/06/2021 01:23, John Snow wrote: > On 5/20/21 3:52 AM, Emanuele Giuseppe Esposito wrote: >> Alsp add a new _qmp_timer field to the QEMUMachine class. >> >> Let's change the default socket timeout to None, so that if >> a subclass needs to add a timer, it can be done by modifying >> this private field. >> >> At the same time, restore the timer to be 15 seconds in iotests.py, to >> give an upper bound to qemu-iotests execution. >> >> Signed-off-by: Emanuele Giuseppe Esposito > > Hi Emanuele: I'm sorry, but with the recent Python PR this no longer > applies to origin/master -- the python files got shuffled around a bit > when I added the new CI tests. > > May I please ask you to rebase? You don't have to re-spin just yet, just > pointing me to the rebase would help me out. Hi John, no problem. I rebased here: https://gitlab.com/eesposit/qemu/-/commits/qemu_iotests_io Let me know if I need to do anything else. I will re-spin later today. Thank you, Emanuele