From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, philmd@linaro.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Phil Dennis-Jordan" <phil@philjordan.eu>
Subject: Re: [PATCH 0/2] fix record/replay on MacOS
Date: Mon, 14 Apr 2025 08:25:37 -0700 [thread overview]
Message-ID: <5b54911e-6b23-4038-b124-dc9bcdaba4d1@linaro.org> (raw)
In-Reply-To: <20250414151422.GB117758@fedora>
On 4/14/25 08:14, Stefan Hajnoczi wrote:
> On Thu, Apr 10, 2025 at 03:55:48PM -0700, Pierrick Bouvier wrote:
>> Recently, it was found that rr tests fail on MacOS, with a replay_mutex_unlock()
>> assertion. This is a recent regression, related to running qemu main event loop
>> in a separate thread, like first commit explain.
>>
>> We first fix the regression, by handling the qemu replay mutex in the same way
>> we deal with BQL.
>> Then, we reenable the disabled test.
>>
>> Pierrick Bouvier (2):
>> system/main: transfer replay mutex ownership from main thread to main
>> loop thread
>> tests/functional/test_aarch64_replay: reenable on macos
>>
>> system/main.c | 4 ++++
>> tests/functional/test_aarch64_replay.py | 2 --
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> --
>> 2.39.5
>>
>
> Thanks, applied to my staging tree:
> https://gitlab.com/stefanha/qemu/commits/staging
>
Thank you Stefan.
> Stefan
prev parent reply other threads:[~2025-04-14 15:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 22:55 [PATCH 0/2] fix record/replay on MacOS Pierrick Bouvier
2025-04-10 22:55 ` [PATCH 1/2] system/main: transfer replay mutex ownership from main thread to main loop thread Pierrick Bouvier
2025-04-12 5:30 ` Nicholas Piggin
2025-04-12 17:24 ` Pierrick Bouvier
2025-04-14 10:25 ` Philippe Mathieu-Daudé
2025-04-14 15:24 ` Pierrick Bouvier
2025-04-15 2:41 ` Nicholas Piggin
2025-04-15 18:31 ` Pierrick Bouvier
2025-04-16 3:16 ` Nicholas Piggin
2025-04-16 18:54 ` Pierrick Bouvier
2025-04-14 10:57 ` Paolo Bonzini
2025-04-10 22:55 ` [PATCH 2/2] tests/functional/test_aarch64_replay: reenable on macos Pierrick Bouvier
2025-04-11 13:42 ` [PATCH 0/2] fix record/replay on MacOS Philippe Mathieu-Daudé
2025-04-14 15:14 ` Stefan Hajnoczi
2025-04-14 15:25 ` Pierrick Bouvier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b54911e-6b23-4038-b124-dc9bcdaba4d1@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).